From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18393 invoked by alias); 3 Jan 2012 20:02:36 -0000 Received: (qmail 18381 invoked by uid 22791); 3 Jan 2012 20:02:34 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 03 Jan 2012 20:02:22 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q03K2Lkr021424 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 3 Jan 2012 15:02:22 -0500 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q03K2Js9012858 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO) for ; Tue, 3 Jan 2012 15:02:21 -0500 Message-ID: <4F035ECB.8060206@redhat.com> Date: Tue, 03 Jan 2012 20:02:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [RFC] Initial pass at supporting the Go language References: <20111228210206.B6B762461C9@ruffy.mtv.corp.google.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00109.txt.bz2 On 01/02/2012 11:13 AM, Tom Tromey wrote: >>>>>> "Doug" == Doug Evans writes: > Doug> + And if not, it should be clearly documented why not. > Doug> + OTOH, why are we demangling at all here? > Doug> + new_symbol_full assumes we return the mangled name. > Doug> + I realize things are changing in this area, I just forget how. */ > Doug> + if (cu->language == language_go) > Doug> + { > Doug> +#if 0 > Doug> + demangled = cu->language_defn->la_demangle (mangled, 0); > Doug> +#else > Doug> + /* This is a lie, but we already lie to the caller new_symbol_full. > Doug> + This just undoes that lie until things are cleaned up. */ > Doug> + demangled = NULL; > Doug> +#endif > > I've CC'd Keith to see if he can clear this up. I'm not sure what the question is... This is the workaround to demangle DW_AT_[MIPS_]linkage_name if available instead of computing the physname. It should only be done for C++ and Java. Did you want me to do something? Or ? Keith