Re: commands.h and cli/cli-decode.h dups

Tom Tromey
2012-01-03T14:57:06Z

>>>>> "Pedro" == Pedro Alves <alves.ped@gmail.com> writes:

Pedro> So this patch does the next step after Andrew's changes.
Pedro> It eliminates the declaration duplication, by removing
Pedro> the "public" declarations from cli-decode.h, and the private
Pedro> interfaces from command.h. There are perhaps functions that
Pedro> are "public" today that shouldn't, but we can move the
Pedro> declarations then if we fix the uses.
Pedro> It then also adds a couple of comments to the headers to
Pedro> indicate their purposes.

Pedro> Comments?

I am totally in favor of it.
I think duplication of this sort is a "worst practice".

Tom