From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19234 invoked by alias); 27 Dec 2011 16:26:42 -0000 Received: (qmail 19224 invoked by uid 22791); 27 Dec 2011 16:26:41 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e24smtp03.br.ibm.com (HELO e24smtp03.br.ibm.com) (32.104.18.24) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 Dec 2011 16:26:28 +0000 Received: from /spool/local by e24smtp03.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 27 Dec 2011 14:26:25 -0200 Received: from mailhub1.br.ibm.com ([9.18.232.109]) by e24smtp03.br.ibm.com ([10.172.0.139]) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 27 Dec 2011 14:26:11 -0200 Received: from d24av04.br.ibm.com (d24av04.br.ibm.com [9.8.31.97]) by mailhub1.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pBRGRDsF2089100 for ; Tue, 27 Dec 2011 14:27:13 -0200 Received: from d24av04.br.ibm.com (loopback [127.0.0.1]) by d24av04.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pBRGPveB013186 for ; Tue, 27 Dec 2011 14:25:57 -0200 Received: from [9.8.2.216] ([9.8.2.216]) by d24av04.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id pBRGPvkJ013179; Tue, 27 Dec 2011 14:25:57 -0200 Message-ID: <4EF9F1A1.2090302@linux.vnet.ibm.com> Date: Tue, 27 Dec 2011 16:49:00 -0000 From: Edjunior Barbosa Machado User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.23) Gecko/20110922 Lightning/1.0b2 Thunderbird/3.1.15 MIME-Version: 1.0 To: brobecker@adacore.com CC: gdb-patches@sourceware.org Subject: Re: [RFA] Ignore data minimal symbols for breakpoint linespecs References: <1324548943-26819-1-git-send-email-brobecker@adacore.com> <20111227041110.GA23376@adacore.com> In-Reply-To: <20111227041110.GA23376@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit x-cbid: 11122716-9254-0000-0000-000007AAE62D X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00844.txt.bz2 On 12/27/2011 02:11 AM, Joel Brobecker wrote: >> gdb/ChangeLog: >> >> * linespec.c (struct collect_minsyms) [list_mode]: New field. >> (add_minsym): Ignore data symbols if not in list mode. >> (search_minsyms_for_name): Set local.list_mode. >> >> gdb/testsuite/ChangeLog: >> >> * gdb.base/dmsym.c, gdb.base/dmsym_main.c, gdb.base/dmsym.exp: >> New files. > > I would normally wait to give the original author (Tom in this case) > some time to comment, but given that it fixes a couple of regressions > as well, and the fact that Jan is OK, I went ahead and checked it in. > If Tom has some comments, I don't mind fixing or reverting at all. > > This is HEAD only. I think we'll want that for the branch, but I'll > wait for Tom's feedback, if any. > Hi, I noticed this patch unfortunately caused around 300 regressions in the testsuite running on ppc64, with failures in several testcases such as: gdb.asm/asm-source.exp gdb.base/solib-weak.exp gdb.base/break-interp.exp gdb.cp/cmpd-minsyms.exp gdb.cp/exception.exp gdb.cp/meth-typedefs.exp gdb.cp/ovsrch.exp and others. Please let me know if you need further info or the testsuite results. Thanks, -- Edjunior