From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5446 invoked by alias); 20 Dec 2011 17:47:23 -0000 Received: (qmail 5432 invoked by uid 22791); 20 Dec 2011 17:47:22 -0000 X-SWARE-Spam-Status: No, hits=-5.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 20 Dec 2011 17:47:06 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pBKHl5KV029628 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 20 Dec 2011 12:47:05 -0500 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id pBKHkvVT011113 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 20 Dec 2011 12:47:03 -0500 Message-ID: <4EF0CA0F.20306@redhat.com> Date: Tue, 20 Dec 2011 17:48:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0 MIME-Version: 1.0 To: Tom Tromey CC: "gp >> \"gdb-patches@sourceware.org ml\"" Subject: Re: [RFA] Updated path expression computations for varobj trees References: <4EEBCC7D.4020103@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00686.txt.bz2 On 12/20/2011 07:23 AM, Tom Tromey wrote: >>>>>> "Keith" == Keith Seitz writes: > > Keith> * lib/mi-support.exp: Expand comments about PATH_EXPR. > Keith> (varobj_tree::get_path_expr): Assume that all varobjs are > Keith> compound unless they are known simple types. > Keith> Adjust path expressions based on parent type, path parent type, > Keith> and tree language. > Keith> (varobj_tree::walk_tree): Add LANGUAGE parameter and save it into > Keith> the root varobj. > Keith> (mi_walk_varobj_tree): Add LANGUAGE parameter. > > This is ok. > > I'm not super fond of the type regexp thing, but I suppose we can always > enhance it more later if need be. I am not very fond of it, either, but let me see if I can fiddle with it one more time. I've thought of something that might work. I'll send a note to the list one way or the other. Thank you for taking a look. Keith