From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25607 invoked by alias); 19 Dec 2011 06:26:26 -0000 Received: (qmail 25559 invoked by uid 22791); 19 Dec 2011 06:26:24 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,TW_CP X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 19 Dec 2011 06:26:10 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1RcWfp-0006Av-AF from Yao_Qi@mentor.com ; Sun, 18 Dec 2011 22:26:09 -0800 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Sun, 18 Dec 2011 22:26:09 -0800 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.1.289.1; Sun, 18 Dec 2011 22:26:08 -0800 Message-ID: <4EEED8FB.4040103@codesourcery.com> Date: Mon, 19 Dec 2011 06:50:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:8.0) Gecko/20111110 Thunderbird/8.0 MIME-Version: 1.0 To: Jan Kratochvil CC: Hui Zhu , gdb-patches ml Subject: Re: [obv] Fix unused-but-set-variable error [Re: [OB] Fix linux-low.c build error] References: <20111218192239.GA25401@host2.jankratochvil.net> <20111218205826.GA15385@host2.jankratochvil.net> In-Reply-To: <20111218205826.GA15385@host2.jankratochvil.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00622.txt.bz2 On 12/19/2011 04:58 AM, Jan Kratochvil wrote: > Checked in this alternative fix to not break the next nightly builds. > > I believe it now should pass also on Ubuntu, tested it with artificial > warn_unused_result attribute for `write'. > > > Regards, > Jan > > > http://sourceware.org/ml/gdb-cvs/2011-12/msg00185.html > > --- src/gdb/gdbserver/ChangeLog 2011/12/18 15:49:04 1.529 > +++ src/gdb/gdbserver/ChangeLog 2011/12/18 20:55:08 1.530 > @@ -1,3 +1,11 @@ > +2011-12-18 Jan Kratochvil > + > + * linux-low.c (linux_create_inferior): Put empty if clause for write. > + > + Revert: > + 2011-12-18 Hui Zhu > + * linux-low.c (linux_create_inferior): Save return value to ret. > + This reminds me that I committed a similar patch some days ago. Here is a patch to revert. -- Yao (齐尧) * tracepoint.c (gdb_ust_thread): Put an empty if clause for write. Revert: 2011-12-14 Yao Qi * tracepoint.c (gdb_ust_thread): Don't ignore return value of write. Index: gdb/gdbserver/tracepoint.c =================================================================== RCS file: /cvs/src/src/gdb/gdbserver/tracepoint.c,v retrieving revision 1.38 diff -u -r1.38 tracepoint.c --- gdb/gdbserver/tracepoint.c 15 Dec 2011 12:40:03 -0000 1.38 +++ gdb/gdbserver/tracepoint.c 19 Dec 2011 06:17:49 -0000 @@ -8122,8 +8122,8 @@ strcpy (cmd_buf, ""); } - /* Fix compiler's warning: ignoring return value of 'write'. */ - ret = write (fd, buf, 1); + if (write (fd, buf, 1) < 0) + /* Errors ignored. */; close (fd); } }