From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5813 invoked by alias); 5 Dec 2011 08:12:59 -0000 Received: (qmail 5802 invoked by uid 22791); 5 Dec 2011 08:12:57 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 05 Dec 2011 08:12:44 +0000 Received: from nat-jpt.mentorg.com ([192.94.33.2] helo=PR1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1RXTfG-0001MU-8j from Yao_Qi@mentor.com ; Mon, 05 Dec 2011 00:12:42 -0800 Received: from [127.0.0.1] ([172.16.63.104]) by PR1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Mon, 5 Dec 2011 17:12:40 +0900 Message-ID: <4EDC7CF2.1090505@codesourcery.com> Date: Mon, 05 Dec 2011 08:12:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1 MIME-Version: 1.0 To: oza Pawandeep CC: =?UTF-8?B?UGV0ciBIbHV6w61u?= , Tom Tromey , paawan oza , "gdb-patches@sourceware.org" , chandra krishnappa Subject: Re: [PATCH] arm reversible : References: <998639.46560.qm@web112516.mail.gq1.yahoo.com> <4EDAD0EF.20405@codesourcery.com> <4EDB877B.2050903@codesourcery.com> <4EDC0629.5060208@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00113.txt.bz2 On 12/05/2011 01:35 PM, oza Pawandeep wrote: > + (struct insn_decode_record): New Structure for arm insn record. > + (REG_ALLOC): New Macro for reg allocations. > + (MEM_ALLOC): New Macro for memory allocations. Any reason to capitalize "S" in "Structure" and "M" in "Macro"? I think they should be lower-case'ed. -- Yao (齐尧)