From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-85790-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22743 invoked by alias); 4 Dec 2011 23:46:32 -0000
Received: (qmail 22734 invoked by uid 22791); 4 Dec 2011 23:46:31 -0000
X-SWARE-Spam-Status: No, hits=-1.7 required=5.0	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 04 Dec 2011 23:46:17 +0000
Received: from nat-jpt.mentorg.com ([192.94.33.2] helo=PR1-MAIL.mgc.mentorg.com)	by relay1.mentorg.com with esmtp 	id 1RXLlA-000350-7R from Yao_Qi@mentor.com ; Sun, 04 Dec 2011 15:46:16 -0800
Received: from [127.0.0.1] ([172.16.63.104]) by PR1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830);	 Mon, 5 Dec 2011 08:46:14 +0900
Message-ID: <4EDC0629.5060208@codesourcery.com>
Date: Sun, 04 Dec 2011 23:46:00 -0000
From: Yao Qi <yao@codesourcery.com>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1
MIME-Version: 1.0
To: oza Pawandeep <oza.pawandeep@gmail.com>
CC: =?UTF-8?B?UGV0ciBIbHV6w61u?= <petr.hluzin@gmail.com>,  Tom Tromey <tromey@redhat.com>, paawan oza <paawan1982@yahoo.com>,  "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>, chandra krishnappa <chandra_roadking@yahoo.com>
Subject: Re: [PATCH] arm reversible : <phase_2_complete>
References: <998639.46560.qm@web112516.mail.gq1.yahoo.com> <CAK1A=4yYqH9mHuDVmMAD8d9y5X176240pxDr4Ac3bVs8p5jQhw@mail.gmail.com> <m3vcqieb48.fsf@fleche.redhat.com> <CAK1A=4wz=2uU71yFz39EdOMvrLEyR+dX9TEogJ6vRR2Pu4pDNw@mail.gmail.com> <CAK1A=4zrPC2WnP8_F+pF9djgxDsZJMu6hbVMVVZXvC-VoqOHjQ@mail.gmail.com> <m3hb1i95xn.fsf@fleche.redhat.com> <CAK1A=4xgZiBR=iWgo_AbUw2amVZstqyQ3L-M2wm6DWndSh16Cw@mail.gmail.com> <CAK1A=4xBYsQ129h7GmF+KyL_0oz09+Kr0a4A+X-ir41-=DVSug@mail.gmail.com> <CAC=yr6CVW+5gOXCpo_jC+ESxrFWUqb=DakDvbT5URsd+F8Y_ZA@mail.gmail.com> <CAK1A=4zVVw3Y2pVTQ4EZmwcLtQob-QUajTyaSWEk4YQM_9b=MA@mail.gmail.com> <CAK1A=4wQis+_YW=oWBtreGZsXDZfK=FbTQv5uHsb=1Kp15=0-w@mail.gmail.com> <4EDAD0EF.20405@codesourcery.com> <CAK1A=4yLcpXq02hTt7xHEkSj1Z_8jc5Ew_3DY1GzqzWu_u=8gg@mail.gmail.com> <CAK1A=4wT8UrgdaOPDDggvdHBMnEh9b1mNLnOko9s51EV1zTXEQ@mail.gmail.com> <4EDB877B.2050903@codesourcery.com> <CAK1A=4xXnD0f05zXhFDC_f_Z0kroR46r=L5HLnSeTJK7yU9oUg@mail.gmail.com>
In-Reply-To: <CAK1A=4xXnD0f05zXhFDC_f_Z0kroR46r=L5HLnSeTJK7yU9oUg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-12/txt/msg00109.txt.bz2

On 12/05/2011 01:00 AM, oza Pawandeep wrote:
> 	(struct insn_decode_record): New Structure. arm insn record

ChangeLog entry can not be a sentence, but it should be ended with "."
We can say "New structure for arm insn record" or just "New".

> 	(REG_ALLOC): New Macros. use it for reg allocations

"New macro for reg allocations."

> 	(MEM_ALLOC): New Macros. use it for memory allocations

"New macro for memory allocations."

The rest of ChangeLog looks right to me, so I don't have any other
comments on ChangeLog.

-- 
Yao (齐尧)