From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21916 invoked by alias); 29 Nov 2011 23:18:22 -0000 Received: (qmail 21908 invoked by uid 22791); 29 Nov 2011 23:18:21 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_00,TW_RG X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 29 Nov 2011 23:18:04 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1RVWw7-00041i-BI from Kwok_Yeung@mentor.com ; Tue, 29 Nov 2011 15:18:03 -0800 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 29 Nov 2011 15:18:03 -0800 Received: from [0.0.0.0] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Tue, 29 Nov 2011 23:18:00 +0000 Message-ID: <4ED56826.5000804@codesourcery.com> Date: Tue, 29 Nov 2011 23:18:00 -0000 From: Kwok Cheung Yeung User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0) Gecko/20111105 Thunderbird/8.0 MIME-Version: 1.0 To: Tom Tromey CC: Subject: Re: [PATCH] Add the "-info-os" command to MI References: <4E970915.8000207@codesourcery.com> <4ECECFEB.8020807@codesourcery.com> In-Reply-To: Content-Type: multipart/mixed; boundary="------------070300040902030206070701" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00836.txt.bz2 --------------070300040902030206070701 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Content-length: 775 On 29/11/2011 7:01 PM, Tom Tromey wrote: > Two nits... > >>> + { "info-os", { NULL, 0 }, mi_cmd_info_os}, > > mi_cmd_info_os doesn't seem to be declared anywhere. > I think this ought to cause a compilation error. > Oops - I did add a declaration in mi/mi-cmds.h but forgot to include it in the patch. :-) >>> + info_osdata_command (argv [0], 0); > > No space before the '['. > Fixed. Kwok ChangeLog: gdb/ * Makefile.in (SUBDIR_MI_OBS): Add mi-cmd-info.o. (SUBDIR_MI_SRCS): Add mi-cmd-info.c. (mi-cmd-info.o): New rule. * osdata.h (info_osdata_command): New declaration. * osdata.c (info_osdata_command): Change to non-static. * mi/mi-cmds.h (mi_cmd_info_os): New declaration. * mi/mi-cmds.c (mi_cmds): Add -info-os MI command. * mi/mi-cmd-info.c: New. --------------070300040902030206070701 Content-Type: text/plain; name="mi_info-os.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="mi_info-os.patch" Content-length: 5078 Index: Makefile.in =================================================================== RCS file: /cvs/src/src/gdb/Makefile.in,v retrieving revision 1.1178 diff -u -p -r1.1178 Makefile.in --- Makefile.in 20 Nov 2011 08:59:56 -0000 1.1178 +++ Makefile.in 29 Nov 2011 23:04:39 -0000 @@ -207,6 +207,7 @@ SUBDIR_MI_OBS = \ mi-out.o mi-console.o \ mi-cmds.o mi-cmd-env.o mi-cmd-var.o mi-cmd-break.o mi-cmd-stack.o \ mi-cmd-file.o mi-cmd-disas.o mi-symbol-cmds.o mi-cmd-target.o \ + mi-cmd-info.o \ mi-interp.o \ mi-main.o mi-parse.o mi-getopt.o SUBDIR_MI_SRCS = \ @@ -214,7 +215,8 @@ SUBDIR_MI_SRCS = \ mi/mi-cmds.c mi/mi-cmd-env.c \ mi/mi-cmd-var.c mi/mi-cmd-break.c mi/mi-cmd-stack.c \ mi/mi-cmd-file.c mi/mi-cmd-disas.c mi/mi-symbol-cmds.c \ - mi/mi-cmd-target.c mi/mi-interp.c \ + mi/mi-cmd-target.c mi/mi-cmd-info.c \ + mi/mi-interp.c \ mi/mi-main.c mi/mi-parse.c mi/mi-getopt.c SUBDIR_MI_DEPS = SUBDIR_MI_LDFLAGS= @@ -1896,6 +1898,10 @@ mi-cmd-file.o: $(srcdir)/mi/mi-cmd-file. $(COMPILE) $(srcdir)/mi/mi-cmd-file.c $(POSTCOMPILE) +mi-cmd-info.o: $(srcdir)/mi/mi-cmd-info.c + $(COMPILE) $(srcdir)/mi/mi-cmd-info.c + $(POSTCOMPILE) + mi-cmds.o: $(srcdir)/mi/mi-cmds.c $(COMPILE) $(srcdir)/mi/mi-cmds.c $(POSTCOMPILE) Index: osdata.c =================================================================== RCS file: /cvs/src/src/gdb/osdata.c,v retrieving revision 1.13 diff -u -p -r1.13 osdata.c --- osdata.c 21 Nov 2011 16:54:28 -0000 1.13 +++ osdata.c 29 Nov 2011 23:04:39 -0000 @@ -288,7 +288,7 @@ get_osdata_column (struct osdata_item *i return NULL; } -static void +void info_osdata_command (char *type, int from_tty) { struct ui_out *uiout = current_uiout; Index: osdata.h =================================================================== RCS file: /cvs/src/src/gdb/osdata.h,v retrieving revision 1.5 diff -u -p -r1.5 osdata.h --- osdata.h 1 Jan 2011 15:33:12 -0000 1.5 +++ osdata.h 29 Nov 2011 23:04:39 -0000 @@ -49,5 +49,6 @@ void osdata_free (struct osdata *); struct cleanup *make_cleanup_osdata_free (struct osdata *data); struct osdata *get_osdata (const char *type); const char *get_osdata_column (struct osdata_item *item, const char *name); +void info_osdata_command (char *type, int from_tty); #endif /* OSDATA_H */ Index: mi/mi-cmds.c =================================================================== RCS file: /cvs/src/src/gdb/mi/mi-cmds.c,v retrieving revision 1.57 diff -u -p -r1.57 mi-cmds.c --- mi/mi-cmds.c 3 Oct 2011 21:38:31 -0000 1.57 +++ mi/mi-cmds.c 29 Nov 2011 23:04:39 -0000 @@ -90,6 +90,7 @@ struct mi_cmd mi_cmds[] = { "gdb-version", { "show version", 0 }, 0 }, { "inferior-tty-set", { NULL, 0 }, mi_cmd_inferior_tty_set}, { "inferior-tty-show", { NULL, 0 }, mi_cmd_inferior_tty_show}, + { "info-os", { NULL, 0 }, mi_cmd_info_os}, { "interpreter-exec", { NULL, 0 }, mi_cmd_interpreter_exec}, { "list-features", { NULL, 0 }, mi_cmd_list_features}, { "list-target-features", { NULL, 0 }, mi_cmd_list_target_features}, Index: mi/mi-cmds.h =================================================================== RCS file: /cvs/src/src/gdb/mi/mi-cmds.h,v retrieving revision 1.52 diff -u -p -r1.52 mi-cmds.h --- mi/mi-cmds.h 3 Oct 2011 21:38:31 -0000 1.52 +++ mi/mi-cmds.h 29 Nov 2011 23:04:39 -0000 @@ -72,6 +72,7 @@ extern mi_cmd_argv_ftype mi_cmd_file_lis extern mi_cmd_argv_ftype mi_cmd_gdb_exit; extern mi_cmd_argv_ftype mi_cmd_inferior_tty_set; extern mi_cmd_argv_ftype mi_cmd_inferior_tty_show; +extern mi_cmd_argv_ftype mi_cmd_info_os; extern mi_cmd_argv_ftype mi_cmd_interpreter_exec; extern mi_cmd_argv_ftype mi_cmd_list_features; extern mi_cmd_argv_ftype mi_cmd_list_target_features; Index: mi/mi-cmd-info.c =================================================================== RCS file: mi/mi-cmd-info.c diff -N mi/mi-cmd-info.c --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ mi/mi-cmd-info.c 29 Nov 2011 23:04:39 -0000 @@ -0,0 +1,37 @@ +/* MI Command Set - information commands. + Copyright (C) 2011 Free Software Foundation, Inc. + + This file is part of GDB. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +#include "defs.h" +#include "osdata.h" + +void +mi_cmd_info_os (char *command, char **argv, int argc) +{ + switch (argc) + { + case 0: + info_osdata_command ("", 0); + break; + case 1: + info_osdata_command (argv[0], 0); + break; + default: + error (_("-info-os: Usage: [INFOTYPE]")); + break; + } +} --------------070300040902030206070701--