From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24212 invoked by alias); 23 Nov 2011 00:35:46 -0000 Received: (qmail 24006 invoked by uid 22791); 23 Nov 2011 00:35:45 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from elasmtp-banded.atl.sa.earthlink.net (HELO elasmtp-banded.atl.sa.earthlink.net) (209.86.89.70) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 23 Nov 2011 00:35:31 +0000 Received: from [70.170.59.51] (helo=macbook2.local) by elasmtp-banded.atl.sa.earthlink.net with esmtpa (Exim 4.67) (envelope-from ) id 1RT0oE-0000ZM-Lk for gdb-patches@sourceware.org; Tue, 22 Nov 2011 19:35:30 -0500 Message-ID: <4ECC3FD2.1000309@earthlink.net> Date: Wed, 23 Nov 2011 00:35:00 -0000 From: Stan Shebs User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:8.0) Gecko/20111105 Thunderbird/8.0 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [PATCH 35/358] Fix -Wsahdow warnings References: <87obw470hx.fsf@gmail.com> In-Reply-To: <87obw470hx.fsf@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-ELNK-Trace: ae6f8838ff913eba0cc1426638a40ef67e972de0d01da9407009697792690b86b11444837f9d0b69350badd9bab72f9c350badd9bab72f9c350badd9bab72f9c X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00609.txt.bz2 On 11/22/11 5:25 AM, Andrey Smirnov wrote: [...] - struct symtab_and_line sal; + struct symtab_and_line las; While clever and amusing, this is probably a bad idea for the long run; without any comment explaining it, some future hacker is really really going to want to change it back to "sal", and when enough time has passed, no one will remember why they should object. Better to use something dull and predictable like "sal2". Stan stan@codesourcery.com