Re: [PATCH 22/348] Fix -Wsahdow warnings

Mike Frysinger
2011-11-22T15:28:07Z

[-- Attachment #1: Type: Text/Plain, Size: 957 bytes --]

On Tuesday 22 November 2011 09:04:07 Andrey Smirnov wrote:
> On Tue, Nov 22, 2011 at 8:35 PM, Marek Polacek <mpolacek@redhat.com> wrote:
> > On 11/22/2011 02:33 PM, Andrey Smirnov wrote:
> >>> Is the typo intentional?
> >>
> >> Sorry about that. No it isn't. Please ignore that particular patch I'll
> >> send corrected version soon(I'm in the middle of a git rebase
> >> --interactive, so I can't edit that particular commit just yet).
> >
> > That typo is in other patches too.
>
> OK, once again, sorry about that, I'll recheck all the patches related
> to bcache.c, for now please ignore those.

please condense down your patches if you resend. there's way too many little
tiny ones that really should be squashed into a single changeset.

your ChangeLogs are also incorrect. it should not be:
* bcache.c (expand_hash_table): Fix -Wshadow warnings.
but rather:
* bcache.c (expand_hash_table): Rename bcache to cache.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]