Re: [PATCH 22/348] Fix -Wsahdow warnings

Tom Tromey
2011-11-22T18:24:52Z

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

>> please condense down your patches if you resend. there's way too many
>> little tiny ones that really should be squashed into a single
>> changeset.

Joel> In my view, if the patches can be checked in independently, then
Joel> it is a good thing that they are split. Imagine the situation where
Joel> one of these changes is bad, we'd then be able to revert that one
Joel> patch, rather than fixing by hand.

I think a bit more batching would be ok.
It doesn't really matter to me, though, I will go through them all
either way.

>> your ChangeLogs are also incorrect. it should not be:
>> * bcache.c (expand_hash_table): Fix -Wshadow warnings.
>> but rather:
>> * bcache.c (expand_hash_table): Rename bcache to cache.

Joel> I'm 50/50 on this. I don't mind either way. What do others think?
Joel> Is that really that important that we must create boring extra work
Joel> for Andrey?

I can't imagine rewriting 348 ChangeLog entries.

Tom