Re: [PATCH 022/238] [misc.] bcache.c: -Wshadow fix.

Andrey Smirnov
2011-12-20T19:28:18Z

> Tom> For the record, I am approving the ones I think are useful.
> Tom> I still think that the best course is to use -Wshadow in conjunction
> Tom> with a newer GCC; and to implement configury to check for this GCC
> Tom> feature.
>
> Andrey> I washed my hands of the issue, so I won't be sending patches
> Andrey> implementing said configury or any code to that effect anytime soon, but
> Andrey> I think that statement for the record will probably get lost among all
> Andrey> the messages on -Wshadow topic, and you're going to have to repeat
> Andrey> yourself once the issue is brought up again in the future :)
>
> Ok, I see.
> Does that mean you are abandoning the whole series?

No, not at all, just the arguing on whether -Wshadow should be enabled
by default or not part.

Andrey Smirnov