From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9342 invoked by alias); 1 Nov 2011 18:06:03 -0000 Received: (qmail 9332 invoked by uid 22791); 1 Nov 2011 18:06:02 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Nov 2011 18:05:48 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1RLIiZ-0005xB-G3 from meador_inge@mentor.com ; Tue, 01 Nov 2011 11:05:47 -0700 Received: from na2-mail.mgc.mentorg.com ([134.86.114.213]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 1 Nov 2011 11:04:36 -0700 Received: from [172.30.5.181] ([172.30.5.181]) by na2-mail.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 1 Nov 2011 12:05:46 -0600 Message-ID: <4EB034F3.9000408@codesourcery.com> Date: Tue, 01 Nov 2011 18:06:00 -0000 From: Meador Inge User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.23) Gecko/20110921 Lightning/1.0b2 Thunderbird/3.1.15 MIME-Version: 1.0 To: pmuldoon@redhat.com CC: gdb-patches@sourceware.org Subject: Re: [python] [patch] PR python/13345 References: <4EAFFCEB.6040401@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00023.txt.bz2 On 11/01/2011 09:14 AM, Phil Muldoon wrote: > Meador Inge writes: > >> On 10/31/2011 10:51 AM, Phil Muldoon wrote: >> >>> This patch fixes a case where the tilde (~) command was being passed to >>> Python via the "source" command. Python does not understand what to do >>> with a tilde, so we have to expand it first. >> >> While I can't give an OK, I did review this and was able to reproduce >> the stated problem and the patch fixes it. So, LGTM. What about >> a test case, though? You could construct a relative path to a >> test directory from '~/'. > > The only addition in the patch was tilde_expand, and an additional error > check. tilde_expand is a readline function. So we would be testing > that, more or less. I do normally write regression tests, but I felt > for this one it was not necessary as the patch is somewhat trivial. > Plus I am not sure how constructing a path with a ~ in it would work on > mingw builds? If so, and we really do want one, I can attempt to write > one. That seems reasonable. I agree the test case can be skipped. Just figured I would ask ... -- Meador Inge CodeSourcery / Mentor Embedded