From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2354 invoked by alias); 1 Nov 2011 14:07:14 -0000 Received: (qmail 2342 invoked by uid 22791); 1 Nov 2011 14:07:13 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Nov 2011 14:06:44 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1RLEzC-0002ej-W1 from meador_inge@mentor.com ; Tue, 01 Nov 2011 07:06:43 -0700 Received: from na2-mail.mgc.mentorg.com ([134.86.114.213]) by svr-orw-fem-01.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 1 Nov 2011 07:06:42 -0700 Received: from [172.30.5.181] ([172.30.5.181]) by na2-mail.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 1 Nov 2011 08:06:41 -0600 Message-ID: <4EAFFCEB.6040401@codesourcery.com> Date: Tue, 01 Nov 2011 14:07:00 -0000 From: Meador Inge User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.23) Gecko/20110921 Lightning/1.0b2 Thunderbird/3.1.15 MIME-Version: 1.0 To: pmuldoon@redhat.com CC: gdb-patches@sourceware.org Subject: Re: [python] [patch] PR python/13345 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00007.txt.bz2 On 10/31/2011 10:51 AM, Phil Muldoon wrote: > This patch fixes a case where the tilde (~) command was being passed to > Python via the "source" command. Python does not understand what to do > with a tilde, so we have to expand it first. While I can't give an OK, I did review this and was able to reproduce the stated problem and the patch fixes it. So, LGTM. What about a test case, though? You could construct a relative path to a test directory from '~/'. -- Meador Inge CodeSourcery / Mentor Embedded http://www.mentor.com/embedded-software