From: Yao Qi <yao@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [patch, gdbserver] Uninsert bpkt when regular and fast tracepoint are set at the same address
Date: Mon, 31 Oct 2011 09:41:00 -0000 [thread overview]
Message-ID: <4EAE58B8.3010302@codesourcery.com> (raw)
In-Reply-To: <4EABEE51.5040801@codesourcery.com>
On 10/29/2011 08:15 PM, Yao Qi wrote:
> Another thing I want you to help me to understand is what is wrong with
> my patch? In my patch, the interpretation of shadow is different from
> yours. In my patch, when raw breakpoint and fast tracepoint jump is set
> at the same address, shadow of breakpoint is a copy of jump insn. It
> makes easier in uninsert breakpoint, because check_mem_write is not
> needed, and we can simply write memory. The only problem I can think of
> is about removing fast tracepoint first, and leaving breakpoint still
> there. Except this problem, is there any more problem?
I find my patch caused some regression on my local tracepoint test
cases, and I figured out why my patch is wrong. Please ignore this
question.
--
Yao (é½å°§)
next prev parent reply other threads:[~2011-10-31 8:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-27 7:04 Yao Qi
2011-10-27 16:09 ` Pedro Alves
2011-10-29 12:40 ` Yao Qi
2011-10-31 9:41 ` Yao Qi [this message]
2011-10-31 13:28 ` Pedro Alves
2011-10-27 19:47 ` Stan Shebs
2011-10-27 21:23 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EAE58B8.3010302@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox