From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30186 invoked by alias); 18 Oct 2011 19:31:32 -0000 Received: (qmail 30172 invoked by uid 22791); 18 Oct 2011 19:31:31 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Oct 2011 19:31:12 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9IJVBCc015372 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 18 Oct 2011 15:31:11 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p9IJV8Rg002929 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 18 Oct 2011 15:31:10 -0400 Message-ID: <4E9DD3FC.1060407@redhat.com> Date: Tue, 18 Oct 2011 20:14:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 MIME-Version: 1.0 To: Abhijit Halder CC: gdb-patches@sourceware.org Subject: Re: [PATCH] [PR 9514] Fixing parse error for "pointer to a function pointer" References: <201109291210.01022.pedro@codesourcery.com> <4E8E18FC.4030705@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00508.txt.bz2 On 10/17/2011 03:59 AM, Abhijit Halder wrote: >> +FAIL: gdb.base/code-expr.exp: (int ** @code) >> +FAIL: gdb.base/cvexpr.exp: (int ** const) >> > With latest CVS code the patch has no regression: I still see those as regressions (gdb 7.3.50.20111018-cvs): $ diff -p testsuite/gdb.sum.0 testsuite/gdb.sum | grep "int \*\*" PASS: gdb.base/code-expr.exp: (@code int **) ! PASS: gdb.base/code-expr.exp: (int ** @code) PASS: gdb.base/code-expr.exp: (@code int **) ! FAIL: gdb.base/code-expr.exp: (int ** @code) PASS: gdb.base/cvexpr.exp: (const int **) ! PASS: gdb.base/cvexpr.exp: (int ** const) PASS: gdb.base/cvexpr.exp: (const int **) ! FAIL: gdb.base/cvexpr.exp: (int ** const) Do I have an outdated version of the patch? diff --git a/gdb/c-exp.y b/gdb/c-exp.y index b850179..60004f3 100644 --- a/gdb/c-exp.y +++ b/gdb/c-exp.y @@ -944,6 +944,8 @@ abs_decl: '*' { push_type (tp_pointer); $$ = 0; } | '*' abs_decl { push_type (tp_pointer); $$ = $2; } + | abs_decl '*' + { push_type (tp_pointer); $$ = $1; } | '&' { push_type (tp_reference); $$ = 0; } | '&' abs_decl Am I missing something else? Keith