From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18908 invoked by alias); 18 Oct 2011 01:26:33 -0000 Received: (qmail 18895 invoked by uid 22791); 18 Oct 2011 01:26:32 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Oct 2011 01:26:17 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1RFyRc-0003ge-K3 from Stan_Shebs@mentor.com ; Mon, 17 Oct 2011 18:26:16 -0700 Received: from na2-mail.mgc.mentorg.com ([134.86.114.213]) by svr-orw-fem-01.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 17 Oct 2011 18:26:16 -0700 Received: from [172.30.3.53] ([172.30.3.53]) by na2-mail.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 17 Oct 2011 19:26:14 -0600 Message-ID: <4E9CD5B5.5040209@mentor.com> Date: Tue, 18 Oct 2011 01:44:00 -0000 From: Stan Shebs User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20110922 Thunderbird/3.1.15 MIME-Version: 1.0 To: Eli Zaretskii CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Tracing notes and metadata References: <4E9C5112.9070705@mentor.com> <83d3dvwphm.fsf@gnu.org> In-Reply-To: <83d3dvwphm.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00489.txt.bz2 On 10/17/2011 09:29 AM, Eli Zaretskii wrote: >> Date: Mon, 17 Oct 2011 09:00:18 -0700 >> From: Stan Shebs >> >> With this patch, any arguments to tstart and tstop are recorded with the >> trace run as free-form text, and reported as part of its status. Also, >> there is a trace-user variable (which is free form text which is >> typically constant and you can set in your .gdbinit), and set/show >> variables for the start and stop notes as well. >> >> In addition, this patch adds start/stop timestamps and per-tracepoint >> hit counts and traceframe usage. >> >> The patch still needs testsuite and NEWS, but considering the user >> interface tinkering, it seemed like a good idea to solicit feedback >> before committing to all the details. > The documentation part is okay, but please add some overview of the > notes, to serve as the glue to the description of the commands. As I > read the patch, I was wondering whether there's only one note that can > be set by either "tstart" or "tstop" (and then what happens if you > give arguments to "tstop" when "tstart" already provided a note?), or > two separate and independent notes (in which case why do we have > "trace-stop-notes", but no "trace-start-notes"?). Instead of > disclosing all this piecemeal and leaving the reader with a reasonable > doubt, why not explain it once and for all? OK, needs more explanation then. :-) The tstart note is the summary of the trace run as a whole, while the stop note only applies if the trace was manually stopped via tstop, vs stopping due to trace buffer full, bytecode dividing by zero, etc. In practice, one would only expect to supply a stop note if the trace had to be manually stopped by someone else ("tstop I needed to stop your run so I could test my workaround for bug 12043 -sts"), so the original person running the trace has an explanation of what happened - and can interpret the possibly-incomplete trace results accordingly. > Btw, didn't the socializing parties ask you for a way to _add_ to an > existing note, rather than overwriting it? The way you designed it, > fixing a single typo requires retyping (or copy/pasting) the whole > thing, which sounds inconvenient. > No, you're the first person to mention adding actually. I think the mental model is that the notes are typically one-liners, and we do have line-editing capability available from readline. I think if things really needed to be much more elaborate in a multi-user setting, the users would set up a wiki or virtual signup sheets or some such, and at that point it gets generally out of scope for GDB. ("tstart http://signup.intranet.com/34129") Stan