From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29585 invoked by alias); 13 Oct 2011 08:05:15 -0000 Received: (qmail 29571 invoked by uid 22791); 13 Oct 2011 08:05:12 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 13 Oct 2011 08:04:53 +0000 Received: from nat-jpt.mentorg.com ([192.94.33.2] helo=PR1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1REGHc-0007lk-Pk from Yao_Qi@mentor.com ; Thu, 13 Oct 2011 01:04:52 -0700 Received: from [127.0.0.1] ([172.16.63.104]) by PR1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Thu, 13 Oct 2011 17:04:51 +0900 Message-ID: <4E969B83.1030404@codesourcery.com> Date: Thu, 13 Oct 2011 08:05:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:7.0) Gecko/20110923 Thunderbird/7.0 MIME-Version: 1.0 To: Jan Kratochvil CC: gdb-patches@sourceware.org Subject: Re: [commit] [patch] Fix crash on empty DWARF expressions NULL DATA vs. zero SIZE References: <20110713160435.GA19359@host1.jankratochvil.net> <20111012220436.GA30417@host1.jankratochvil.net> In-Reply-To: <20111012220436.GA30417@host1.jankratochvil.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00381.txt.bz2 On 10/13/2011 06:04 AM, Jan Kratochvil wrote: >> gdb/ >> 2011-07-13 Jan Kratochvil >> >> Fix empty DWARF expressions DATA vs. SIZE conditionals. >> * dwarf2loc.c (dwarf2_find_location_expression): Clear *LOCEXPR_LENGTH. >> (dwarf_expr_frame_base_1): Indicate unavailability via zero *LENGTH. >> (locexpr_tracepoint_var_ref): Check only zero SIZE, not zero DATA. >> (loclist_read_variable, loclist_tracepoint_var_ref): Do not check for >> zero DATA. >> * dwarf2loc.h (struct dwarf2_locexpr_baton): Comment DATA vs. SIZE >> validity. >> * dwarf2read.c (struct dwarf_block): Comment DATA validity. >> (dwarf2_fetch_die_location_block, dwarf2_symbol_mark_computed): Do not >> clear DATA on zero SIZE. Jan, This patch causes a build failure, gcc -g -O2 -I. -I../../src/gdb -I../../src/gdb/common -I../../src/gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode -I../../src/gdb/../opcodes/.. -I../../src/gdb/../readline/.. -I../bfd -I../../src/gdb/../bfd -I../../src/gdb/../include -I../libdecnumber -I../../src/gdb/../libdecnumber -I../../src/gdb/gnulib -Ignulib -DTUI=1 -Wall -Wdeclaration-after-statement -Wpointer-arith -Wformat-nonliteral -Wno-pointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Werror -c -o dwarf2read.o -MT dwarf2read.o -MMD -MP -MF .deps/dwarf2read.Tpo ../../src/gdb/dwarf2read.c cc1: warnings being treated as errors ../../src/gdb/dwarf2read.c: In function ‘dwarf2_fetch_die_location_block’: ../../src/gdb/dwarf2read.c:14204: error: ‘retval.data’ may be used uninitialized in this function make[2]: *** [dwarf2read.o] Error 1 -- Yao (齐尧)