From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4307 invoked by alias); 10 Oct 2011 12:34:27 -0000 Received: (qmail 4094 invoked by uid 22791); 10 Oct 2011 12:34:25 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from elasmtp-galgo.atl.sa.earthlink.net (HELO elasmtp-galgo.atl.sa.earthlink.net) (209.86.89.61) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 10 Oct 2011 12:34:10 +0000 Received: from [98.77.21.67] (helo=macbook2.local) by elasmtp-galgo.atl.sa.earthlink.net with esmtpa (Exim 4.67) (envelope-from ) id 1RDF3Z-0000p1-Dz for gdb-patches@sourceware.org; Mon, 10 Oct 2011 08:34:09 -0400 Message-ID: <4E92E639.7000402@earthlink.net> Date: Mon, 10 Oct 2011 12:34:00 -0000 From: Stan Shebs User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: Status of 'blacklist' patch? References: <4E8DCE67.80507@earthlink.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-ELNK-Trace: ae6f8838ff913eba0cc1426638a40ef67e972de0d01da940fbb57060e06266de37d656088375ec54350badd9bab72f9c350badd9bab72f9c350badd9bab72f9c X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00258.txt.bz2 On 10/6/11 4:15 PM, Justin Lebar wrote: > There's a lot of change of terminology from "default breakpoint" to > "displayed codepoint". I know we've debated better substitutes for > "breakpoint", but this patch is maybe not the best place to introduce one. > How about "last displayed symtab and line"? That seems to be > something which is meaningful. Or even "last displayed sal" :-) + * stack.h (clear_last_displayed_symtab_and_line, + last_displayed_symtab_and_line_is_valid, get_last_displayed_pspace, + get_last_displayed_addr, get_last_displayed_symtab, + get_last_displayed_line, get_last_displayed_symtab_and_line): Added + This is why we like periods at the end of each ChangeLog bit - this looks like it got cut off... plus it's good to say as "Declare." as reminder that it's not a code bit that was added. @@ -1394,7 +1397,7 @@ init_cli_cmds (void) char *source_help_text; /* Define the classes of commands. - They will appear in the help list in the reverse of this order. */ + They will appear in the help list in alphabetical order. */ I'm not going to be persnickety about this one, but we really want random comment fixups to be separate patches - took me a moment to decide if this was somehow relevant to the masses of code. +Suppose you wish to step into the functions @code{foo} and @code{bar}, but you +are not interested in stepping through @code{boring}. If you run @code{step} +at line 103, you'll enter @code{boring()}, but if you run @code{next}, you'll +step over both @code{foo} and @code{boring}! What can you do? I would lose the rhetorical question, it's not really adding much. + +@kindex skip delete +@item skip delete @var{n} +Delete the skip with identifier @var{n}. No mass-delete by omitting the argument?? + + /* Architecture we used to create the skiplist entry. May be null + if the entry is pending a shared library load. */ + struct gdbarch *gdbarch; I'm not clear on why we need gdbarch, since CORE_ADDR should always be long enough? + /* Count the number of rows in the table and see if we need space for a + 64-bit address anywhere. */ + ALL_SKIPLIST_ENTRIES (e) + if (entry_num == -1 || e->number == entry_num) + { + num_printable_entries++; + if (e->gdbarch && gdbarch_addr_bit (e->gdbarch) > 32) + address_width = 18; + } Ah, for address printing. My inclination is to say to drop this admirable goal and make a separate patch that attempts to be smart for address printing in breakpoint and skip lists in general. It seems like a nice design might look at actual values in the list and only use wide space if all addresses are large, sort of like how html table layout works. + ui_out_message (current_uiout, 0, _("Not ignoring any files or functions.\n")); "Not skipping" In general, it's looking pretty good! As people have commented previously, regexp would be nice to have, but with this much code, I think it's better to get a first version in, accumulate a little practical experience before deciding about which additional features to add. (Between Moz and GCC, there are going to be lots of users I think. :-) ) Also, in thumbing back through old discussion, I notice that the last state was that you had submitted paperwork for copyright assignment, but not received anything, and I don't remember getting any email adding you to the "has assignments" list. Did you ever get the confirmation from the FSF? Stan stan@codesourcery.com