[ping 2]: [PATCH] Fix that different function breakpoints are set at same pc address (PR gdb/12703)

Yao Qi
2011-10-09T15:06:58Z

On 09/27/2011 06:44 PM, Yao Qi wrote:
> http://sourceware.org/ml/gdb-patches/2011-06/msg00370.html
>
> I regression tested this patch on armv7l-unknown-linux-gnueabi with
> {-mthumb, -marm}, no new fails. OK for mainline?
>

Ping again.

>> > gdb/
>> > * arm-tdep.c (thumb_analyze_prologue): Check condition for 32-bit
>> > Thumb-2 instructions.
>> >
>> > diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c
>> > index 2dd8c9e..7f5a0e1 100644
>> > --- a/gdb/arm-tdep.c
>> > +++ b/gdb/arm-tdep.c
>> > @@ -832,8 +832,9 @@ thumb_analyze_prologue (struct gdbarch *gdbarch,
>> > constant = read_memory_unsigned_integer (loc, 4, byte_order);
>> > regs[bits (insn, 8, 10)] = pv_constant (constant);
>> > }
>> > - else if ((insn & 0xe000) == 0xe000)
>> > + else if ((insn & 0xe000) == 0xe000 && (insn & 0x1800) != 0)
>> > {
>> > + /* 32-bit Thumb-2 instructions. */
>> > unsigned short inst2;
>> >
>> > inst2 = read_memory_unsigned_integer (start + 2, 2,

--
Yao (é½å°§)