From: Keith Seitz <keiths@redhat.com>
To: Abhijit Halder <abhijit.k.halder@gmail.com>
Cc: "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: PING: [PATCH] Fixing parse errors in c-exp.y
Date: Mon, 26 Sep 2011 19:12:00 -0000 [thread overview]
Message-ID: <4E80C318.1000800@redhat.com> (raw)
In-Reply-To: <CAOhZP9yJmAhfHU_A_UR4xiVkijzbYKUb3tjbdNYnsYTZQHsk+g@mail.gmail.com>
On 09/24/2011 02:18 AM, Abhijit Halder wrote:
> This patch is about fixing parse error coming when gdb tries to parse
> a pointer to a function pointer. e.g. (int)(**)(int) and the
> associated problem, defined in PR 9837, which says wrong parsing when
> pointers appear in function argument e.g. (int)(*)(int*)
Thank you for looking into this issue -- I have recently stumbled upon
this (again), and I am glad someone is attempting to fix it. It is
definitely not an easy task (which is why this has been sitting broken
for so long).
> Please review this.
I have applied your patch to HEAD and run the test suite. Unfortunately,
the proposed patch causes quite a few regressions:
! FAIL: gdb.base/code-expr.exp: (int ** @code)
! FAIL: gdb.base/cvexpr.exp: (int ** const)
! FAIL: gdb.cp/cpexprs.exp: print base::overload(base&) const
! FAIL: gdb.cp/cpexprs.exp: print base::overload(char*) const
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator*(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator%(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator-(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator>>(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator!=(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator>(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator>=(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator|(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator&&(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator=(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator+=(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator*=(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator%=(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator>>=(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator|=(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator,(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator/(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator+(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator<<(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator==(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator<(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator<=(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator&(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator^(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator||(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator-=(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator/=(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator<<=(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator&=(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator^=(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator->*(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator[](foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator()(foo&)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator delete(void*)
! FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator delete(void*)
! FAIL: gdb.cp/overload.exp: print foo::overload1arg(char***)
These will need to be fixed before a serious review of this patch can
proceed.
Keith
next prev parent reply other threads:[~2011-09-26 18:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-24 10:37 Abhijit Halder
2011-09-24 10:44 ` Abhijit Halder
2011-09-25 8:51 ` Abhijit Halder
2011-09-26 19:12 ` Keith Seitz [this message]
2011-09-27 10:44 ` Abhijit Halder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E80C318.1000800@redhat.com \
--to=keiths@redhat.com \
--cc=abhijit.k.halder@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox