On 09/14/2011 07:55 PM, Pedro Alves wrote:

>
> There may be some fail/passes done from within gdb.exp procedures that
> won't get that $syscall diferenciator, thus we can end up with
> more than one UNTESTED/FAIL/PASS with the same message on gdb.sum/gdb.log.
> It'd be better to use $pf_prefix instead (grep for uses in the testsuite).
>
>

pf_prefix is set at the entry of proc disp_step_cross_syscall, and 
restored at the end of it.

>
> We need to do something for systems that can't set a breakpoint in
> the vsyscall page though (mine can't).  The test is surely failing there.
>

This is improved by adding another matching in inserting breakpoint on 
syscall insns like this,

        -re "Cannot insert breakpoint .*${gdb_prompt} $" {
            # This syscall insn may be in vsyscall page, and we can't 
set a breakpoint
            # there on some systems.
            fail "break on syscall insns"
            set pf_prefix $old_pf_prefix
            return -1
        }

>
> In the vfork test:
>
>> +      global = 1;
>
> Is the variable used for anything?
>

It was for checking vfork'ed child process executed correctly.  variable 
`global' is useless now.  Removed.

I'll check this patch in tomorrow, if no comments.

-- 
Yao (齐尧)