Re: [patch 1/2] Displaced stepping across fork/vfork

Yao Qi
2011-09-14T14:25:50Z

On 09/14/2011 07:32 PM, Pedro Alves wrote:
>> > The past tense ("was executed") is better here. Copied your suggestion
>> > directly. :)
> You forgot to copy a couple "the"s though. :-)
>

Oops. I missed two "the" in the first line of comment. Added them.

> Does the arm_displaced_step_fixup handler ever do more than
> just adjusting the PC for syscalls? I see there's a ->cleanup
> callback there that does some things with registers. If so,
> we'll need to do more than just adjusting the PC of the child.
> (A more general fix would run the fixup on the child too
> instead.)
>

A general cleanup routine does some registers restores, but cleanup
routines for svc (arm-linux-tdep.c:arm_linux_cleanup_svc and
arm-tdep.c:cleanup_svc) only adjust PC.

> Otherwise looks okay.
>
> On Wednesday 14 September 2011 11:50:24, Yao Qi wrote:
>> > + regcache_write_pc (child_regcache, parent_pc);
>> > +
>> > + }
> You have a spurious empty line here.

I'll check in with these fixes.

--
Yao (é½å°§)