From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27882 invoked by alias); 7 Sep 2011 23:11:02 -0000 Received: (qmail 27873 invoked by uid 22791); 7 Sep 2011 23:11:01 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Sep 2011 23:10:47 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p87NAj7j008103 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 7 Sep 2011 19:10:46 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p87NAhsp026169 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Wed, 7 Sep 2011 19:10:45 -0400 Message-ID: <4E67F9F3.6030206@redhat.com> Date: Thu, 08 Sep 2011 01:30:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110816 Thunderbird/6.0 MIME-Version: 1.0 To: logitech CC: gdb-patches@sourceware.org Subject: Re: Integration of timed breakpoints into GDB References: <32418104.post@talk.nabble.com> In-Reply-To: <32418104.post@talk.nabble.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-09/txt/msg00128.txt.bz2 On 09/07/2011 10:42 AM, logitech wrote: > Further details about the implementation can be found here > http://www.youtube.com/watch?v=PAFQlxqI7qs&feature=player_embedded#! GDB > Timed breakpoint > > I would highly appreciate comments and feedback from your side regarding the > same. Thank you for submitting your new feature patch. To help facilitate the review of your patch, I urge you to read through CONTRIBUTE (found in src/gdb/ or on the gdb web page http://sourceware.org/gdb/contribute/ ) and make any necessary changes to your contribution mentioned in that file. Specifically: - Generate diffs (for source files) using "-up" options, preferably against CVS HEAD. Instructions for getting CVS HEAD are on the web page at http://sourceware.org/gdb/current/ . No need to send diffs for ChangeLogs and generated files (like gdb/configure). - Read and follow the GNU coding standards. There is more on this on the gdb wiki: http://sourceware.org/gdb/current/onlinedocs/gdbint/Coding-Standards.html . There is also Joel's excellent "cheat sheet" at http://sourceware.org/gdb/wiki/JoelsCodingStyleCheatSheet . - You are not listed in MAINTAINERS, do you and/or your company (if necessary) have an assignment with the FSF? - You did not supply any ChangeLog entry(-ies). - I don't see a test case for this. You should write one. It is mostly a cut-n-paste job today. Don't be afraid to ask for help. [Hint: start with any simple test in gdb.base that uses prepare_for_testing.] - This will require additions to documentation and probably a NEWS entry. Thank you! Keith