From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26790 invoked by alias); 30 Aug 2011 02:51:47 -0000 Received: (qmail 26778 invoked by uid 22791); 30 Aug 2011 02:51:46 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 30 Aug 2011 02:51:28 +0000 Received: (qmail 8889 invoked from network); 30 Aug 2011 02:51:28 -0000 Received: from unknown (HELO ?192.168.0.101?) (yao@127.0.0.2) by mail.codesourcery.com with ESMTPA; 30 Aug 2011 02:51:28 -0000 Message-ID: <4E5C502E.1060902@codesourcery.com> Date: Tue, 30 Aug 2011 02:51:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.20) Gecko/20110805 Lightning/1.0b2 Thunderbird/3.1.12 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: [committed]: combine bfd_lookup_symbol in solib-*.c References: <4E4D318E.704@codesourcery.com> <201108291241.02099.pedro@codesourcery.com> <4E5BBCD9.2060503@codesourcery.com> <201108291733.22228.pedro@codesourcery.com> In-Reply-To: <201108291733.22228.pedro@codesourcery.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00584.txt.bz2 On 08/30/2011 12:33 AM, Pedro Alves wrote: > Thanks. > > On Monday 29 August 2011 17:22:49, Yao Qi wrote: >> +CORE_ADDR >> +gdb_bfd_lookup_symbol (bfd *abfd, >> + int (*match_sym) (asymbol *, const void *), >> + const void *data) >> +{ > > The patch is okay if you remove the "const"s. It's common to > want to increment a counter in `data' or something like that. > > (Try `$ grep iterate_over_ *.h' to see other examples of the pattern). > OK, "const"s are removed, and committed. http://sourceware.org/ml/gdb-cvs/2011-08/msg00135.html -- Yao (齐尧)