From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25136 invoked by alias); 27 Aug 2011 13:17:26 -0000 Received: (qmail 25124 invoked by uid 22791); 27 Aug 2011 13:17:24 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,TW_DB,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: sourceware.org Received: from mail-pz0-f44.google.com (HELO mail-pz0-f44.google.com) (209.85.210.44) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 27 Aug 2011 13:17:10 +0000 Received: by pzk36 with SMTP id 36so6439739pzk.3 for ; Sat, 27 Aug 2011 06:17:10 -0700 (PDT) Received: by 10.142.143.12 with SMTP id q12mr1152689wfd.227.1314451030354; Sat, 27 Aug 2011 06:17:10 -0700 (PDT) Received: from [192.168.1.103] ([115.205.113.237]) by mx.google.com with ESMTPS id e8sm7025649pbc.8.2011.08.27.06.17.06 (version=SSLv3 cipher=OTHER); Sat, 27 Aug 2011 06:17:09 -0700 (PDT) Message-ID: <4E58EECC.7060203@gmail.com> Date: Sat, 27 Aug 2011 13:17:00 -0000 From: asmwarrior User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:6.0) Gecko/20110812 Thunderbird/6.0 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [RFA] 12843 References: <4E56C5A0.60802@redhat.com> <4E57E9EC.8060706@redhat.com> <83liuffdlo.fsf@gnu.org> In-Reply-To: <83liuffdlo.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00532.txt.bz2 On 2011-8-27 16:44, Eli Zaretskii wrote: > What about these: > > break 'file with spaces.c:function:with:colons' > break 'file with spaces.c':'function:with:colons' I would expect only the second one is valid. > This patch checks if ':' is followed by '/' and/or '\\' (depending on definition of IS_DIR_SEPARATOR). If it is, we keep looking for the next terminal in the string. This is problematic for filenames with ":\\" or "://" in them, but locate_first_half has gotten those wrong for a long, long time (in fact, any filename at all with a colon(s) in it). Let's revert back to the old and wrong way. ^_^, the patch should works fine under Windows, because no extra colons is allowed in file names there. asmwarrior ollydbg from codeblocks' forum