From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10411 invoked by alias); 20 Aug 2011 06:26:28 -0000 Received: (qmail 10400 invoked by uid 22791); 20 Aug 2011 06:26:27 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mail-gx0-f169.google.com (HELO mail-gx0-f169.google.com) (209.85.161.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 20 Aug 2011 06:26:13 +0000 Received: by gxk23 with SMTP id 23so2863674gxk.0 for ; Fri, 19 Aug 2011 23:26:12 -0700 (PDT) Received: by 10.142.143.17 with SMTP id q17mr155106wfd.261.1313821572302; Fri, 19 Aug 2011 23:26:12 -0700 (PDT) Received: from [127.0.0.1] ([203.110.240.178]) by mx.google.com with ESMTPS id i8sm2938149pbi.28.2011.08.19.23.26.09 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 19 Aug 2011 23:26:11 -0700 (PDT) Message-ID: <4E4F5486.2080309@playingwithpointers.com> Date: Sat, 20 Aug 2011 06:26:00 -0000 From: Sanjoy Das User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110626 Icedove/3.1.11 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [PATCH 5/7] Add a proxy unwinder. References: <1312903509-25132-1-git-send-email-sanjoy@playingwithpointers.com> <1312903509-25132-6-git-send-email-sanjoy@playingwithpointers.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00384.txt.bz2 > > I'm curious why you approached it this way. > It seemed to me that it'll make writing a reader easier, turning if (reg == RAX) { /* Calculate and set RAX */ } else if (reg == RBX) { /* Set `undefined' */ } /* ... and so on, for every register */ into /* Calculate and set RAX */ /* Calculate and set RSP */ /* ... */ /* (No need to bother about the rest of the register file) */ -- Sanjoy Das http://playingwithpointers.com