From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25728 invoked by alias); 13 Aug 2011 13:45:34 -0000 Received: (qmail 25720 invoked by uid 22791); 13 Aug 2011 13:45:33 -0000 X-SWARE-Spam-Status: No, hits=-0.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: sourceware.org Received: from mail-qw0-f41.google.com (HELO mail-qw0-f41.google.com) (209.85.216.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 13 Aug 2011 13:45:18 +0000 Received: by qwa26 with SMTP id 26so2462829qwa.0 for ; Sat, 13 Aug 2011 06:45:18 -0700 (PDT) Received: by 10.224.202.195 with SMTP id ff3mr1422907qab.189.1313243117114; Sat, 13 Aug 2011 06:45:17 -0700 (PDT) Received: from [192.168.1.106] (c-71-232-220-186.hsd1.vt.comcast.net [71.232.220.186]) by mx.google.com with ESMTPS id eb6sm523196qab.14.2011.08.13.06.45.15 (version=SSLv3 cipher=OTHER); Sat, 13 Aug 2011 06:45:16 -0700 (PDT) Message-ID: <4E467FF1.1050403@gmail.com> Date: Sat, 13 Aug 2011 13:45:00 -0000 From: Jie Zhang User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110626 Icedove/3.1.11 MIME-Version: 1.0 To: gdb-patches@sourceware.org CC: drow@false.org Subject: Remove handling of Hs packet from gdbserver Content-Type: multipart/mixed; boundary="------------060402020903000608060907" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00271.txt.bz2 This is a multi-part message in MIME format. --------------060402020903000608060907 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 203 Dan mentioned to remove Hs, but it seems it has not been done yet: http://sourceware.org/ml/gdb-patches/2003-10/msg00428.html This patch removes it. Tested natively on x86_64 Linux. OK? Regards, Jie --------------060402020903000608060907 Content-Type: text/x-patch; name="gdbserver-remove-Hs.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="gdbserver-remove-Hs.diff" Content-length: 2352 2011-08-13 Jie Zhang * server.c (step_thread): Remove definition. (process_serial_event): Don't handle Hs. * server.h (step_thread): Remove declaration. * target.c (set_desired_inferior): Remove use of step_thread. Index: server.c =================================================================== RCS file: /cvs/src/src/gdb/gdbserver/server.c,v retrieving revision 1.146 diff -u -p -r1.146 server.c --- server.c 21 Jul 2011 23:46:12 -0000 1.146 +++ server.c 13 Aug 2011 13:31:28 -0000 @@ -32,7 +32,6 @@ ptid_t cont_thread; ptid_t general_thread; -ptid_t step_thread; int server_waiting; @@ -2912,8 +2911,6 @@ process_serial_event (void) } else if (own_buf[1] == 'c') cont_thread = thread_id; - else if (own_buf[1] == 's') - step_thread = thread_id; write_ok (own_buf); } Index: server.h =================================================================== RCS file: /cvs/src/src/gdb/gdbserver/server.h,v retrieving revision 1.84 diff -u -p -r1.84 server.h --- server.h 21 Jul 2011 23:46:12 -0000 1.84 +++ server.h 13 Aug 2011 13:31:28 -0000 @@ -282,7 +282,6 @@ void unloaded_dll (const char *name, COR extern ptid_t cont_thread; extern ptid_t general_thread; -extern ptid_t step_thread; extern int server_waiting; extern int debug_threads; Index: target.c =================================================================== RCS file: /cvs/src/src/gdb/gdbserver/target.c,v retrieving revision 1.21 diff -u -p -r1.21 target.c --- target.c 1 Jan 2011 15:33:24 -0000 1.21 +++ target.c 13 Aug 2011 13:31:28 -0000 @@ -31,21 +31,7 @@ set_desired_inferior (int use_general) if (use_general == 1) found = find_thread_ptid (general_thread); else - { - found = NULL; - - /* If we are continuing any (all) thread(s), use step_thread - to decide which thread to step and/or send the specified - signal to. */ - if ((!ptid_equal (step_thread, null_ptid) - && !ptid_equal (step_thread, minus_one_ptid)) - && (ptid_equal (cont_thread, null_ptid) - || ptid_equal (cont_thread, minus_one_ptid))) - found = find_thread_ptid (step_thread); - - if (found == NULL) - found = find_thread_ptid (cont_thread); - } + found = find_thread_ptid (cont_thread); if (found == NULL) current_inferior = (struct thread_info *) all_threads.head; --------------060402020903000608060907--