From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6429 invoked by alias); 22 Jul 2011 02:05:39 -0000 Received: (qmail 6178 invoked by uid 22791); 22 Jul 2011 02:05:38 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 22 Jul 2011 02:05:23 +0000 Received: (qmail 2813 invoked from network); 22 Jul 2011 02:05:22 -0000 Received: from unknown (HELO ?192.168.0.101?) (yao@127.0.0.2) by mail.codesourcery.com with ESMTPA; 22 Jul 2011 02:05:22 -0000 Message-ID: <4E28DADB.40701@codesourcery.com> Date: Fri, 22 Jul 2011 10:01:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.17) Gecko/20110424 Lightning/1.0b2 Thunderbird/3.1.10 MIME-Version: 1.0 To: "Joseph S. Myers" CC: gdb-patches@sourceware.org Subject: Re: [RFA 6/8] New port: TI C6x: gdbserver References: <4E2638CE.7050205@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00604.txt.bz2 On 07/21/2011 09:59 PM, Joseph S. Myers wrote: > In this patch, and also in the main GDB port, I think you've used the > wrong set of register names. Specifically, it appears you used a list > provided by TI on 22 September 2010 as an early draft of the list of DWARF > register numbers for the ABI, which had a typo I pointed out the next day > (NPR should be NRP) and was missing ECR (later inserted in the middle of > the list) and various undocumented control registers (later added at the > end). You should check the list carefully against ABI version 0.9. In In gdb side, yes, a typo should be fixed and four new control registers should be added. > addition, the XML files should reflect the different sets of registers on > each processor variant (for details of what processors have what > undocumented control registers, see the details TI provided on 29 October > 2010 - again, with a subsequent correction; the documented registers are > covered in the ISA manuals or in > include/opcode/tic6x-control-registers.h). > In gdbserver side, we don't have to reflect the different control registers on each C6x variant, because they are not accessible from current ptrace (ptrace only access TSR, RILC, ILC, PC, and CSR). XML files should be revised to reflect the different set ptrace-accessible registers on C6x variant. I'll take care of this. -- Yao (齐尧)