Re: [PATCH] Display var_zinteger as signed

Mark Kettenis
2011-07-04T20:34:19Z

> Date: Mon, 4 Jul 2011 11:09:02 -0700
> From: Joel Brobecker <brobecker@adacore.com>
>
> > 2011-07-04 Andrew Burgess <aburgess@broadcom.com>
> >
> > * cli/cli-setshow.c (do_setshow_command): Display var_zinteger
> > variables as signed, not unsigned.
>
> I'm not a fan of fall throughs, like this, because I think it
> makes the code harder to read, but if no other maintainer has
> an objection to it, then the patch is OK (please wait for a couple
> of days to give everyone else a little time to comment on this).

And if the fallthrough stays, the proper spelling is /* FALLTHROUGH
*/. There are several code analysis tools that understand that
comment as signalling an intentional fallthrough instead of an
unintentional one that they need to warn about.