From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31889 invoked by alias); 5 Jul 2011 08:00:52 -0000 Received: (qmail 31874 invoked by uid 22791); 5 Jul 2011 08:00:51 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mms1.broadcom.com (HELO mms1.broadcom.com) (216.31.210.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Jul 2011 08:00:37 +0000 Received: from [10.9.200.131] by mms1.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.3.2)); Tue, 05 Jul 2011 01:05:26 -0700 X-Server-Uuid: 02CED230-5797-4B57-9875-D5D2FEE4708A Received: from mail-irva-13.broadcom.com (10.11.16.103) by IRVEXCHHUB01.corp.ad.broadcom.com (10.9.200.131) with Microsoft SMTP Server id 8.2.247.2; Tue, 5 Jul 2011 00:59:40 -0700 Received: from [10.177.73.61] (unknown [10.177.73.61]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id 83C5A74D14 for ; Tue, 5 Jul 2011 00:59:39 -0700 (PDT) Message-ID: <4E12C46A.9070804@broadcom.com> Date: Tue, 05 Jul 2011 08:37:00 -0000 From: "Andrew Burgess" User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.18) Gecko/20110616 Lightning/1.0b2 Thunderbird/3.1.11 MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: Re: [PATCH] Display var_zinteger as signed References: <4E11976B.9030100@broadcom.com> <4E11A672.5020808@broadcom.com> <20110704180902.GO2407@adacore.com> In-Reply-To: <20110704180902.GO2407@adacore.com> Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00139.txt.bz2 On 04/07/2011 19:09, Joel Brobecker wrote: >> 2011-07-04 Andrew Burgess >> >> * cli/cli-setshow.c (do_setshow_command): Display var_zinteger >> variables as signed, not unsigned. > > I'm not a fan of fall throughs, like this, because I think it > makes the code harder to read, but if no other maintainer has > an objection to it, then the patch is OK (please wait for a couple > of days to give everyone else a little time to comment on this). > > I'd personally write this: > > case var_integer: > case var_zinteger: > if (c->var_type == var_integer&& *(int *) c->var == INT_MAX) > fputs_filtered ("unlimited", stb->stream); > else > fprintf_filtered (stb->stream, "%d", *(int *) c->var); > The revised patch below removes the fall through from both the signed and unsigned cases (I just couldn't have different code for the two cases). Thanks, Andrew 2011-07-04 Andrew Burgess * cli/cli-setshow.c (do_setshow_command): Display var_zinteger variables as signed, not unsigned. diff --git a/gdb/cli/cli-setshow.c b/gdb/cli/cli-setshow.c index 6acdd91..ef04aac 100644 --- a/gdb/cli/cli-setshow.c +++ b/gdb/cli/cli-setshow.c @@ -358,21 +358,18 @@ do_setshow_command (char *arg, int from_tty, struct cmd_list_element *c) } break; case var_uinteger: - if (*(unsigned int *) c->var == UINT_MAX) - { - fputs_filtered ("unlimited", stb->stream); - break; - } - /* else fall through */ case var_zuinteger: - case var_zinteger: - fprintf_filtered (stb->stream, "%u", *(unsigned int *) c->var); + if (c->var_type == var_uinteger && + *(unsigned int *) c->var == UINT_MAX) + fputs_filtered ("unlimited", stb->stream); + else + fprintf_filtered (stb->stream, "%u", *(unsigned int *) c->var); break; case var_integer: - if (*(int *) c->var == INT_MAX) - { - fputs_filtered ("unlimited", stb->stream); - } + case var_zinteger: + if (c->var_type == var_integer && + *(int *) c->var == INT_MAX) + fputs_filtered ("unlimited", stb->stream); else fprintf_filtered (stb->stream, "%d", *(int *) c->var); break;