From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5651 invoked by alias); 30 Jun 2011 10:26:32 -0000 Received: (qmail 5631 invoked by uid 22791); 30 Jun 2011 10:26:31 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 30 Jun 2011 10:26:08 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5UAPjFt015519 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 30 Jun 2011 06:25:45 -0400 Received: from dhcp-25-89.brq.redhat.com (pdp-11.brq.redhat.com [10.34.24.63]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p5UAPi2v021645; Thu, 30 Jun 2011 06:25:45 -0400 Message-ID: <4E0C4F28.4000703@redhat.com> Date: Thu, 30 Jun 2011 10:26:00 -0000 From: Marek Polacek User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100827 Red Hat Thunderbird/3.1.3 MIME-Version: 1.0 To: Joel Brobecker CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH] gdb.python/py-evthreads.exp: fix racy test (PR testsuite/12649) References: <4E09E2C1.2020909@redhat.com> <20110628155107.GL20676@adacore.com> In-Reply-To: <20110628155107.GL20676@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00485.txt.bz2 On 06/28/2011 05:51 PM, Joel Brobecker wrote: > This is an area where I'm not entirely sure, but we usually use > `$gdb_prompt $' as the anchor. Actually, it doesn't matter. That `$' at the end marks end of the read buffer, not the end of line. > I'm also surprised to see some uses of gdb_expect in gdb.python. > I wonder if we could replace them with uses of gdb_test_multiple > (that would be a separate patch)... Yeah, I was thinking about this change too. I'll try it. Marek