Re: [PATCH v3] gdb: tests: set remotetimeout to gdb_load_timeout for remote targets

Mike Frysinger
2011-07-01T00:19:37Z

On Thu, Jun 30, 2011 at 18:54, Joel Brobecker wrote:
>> v3
>>       - add comments to new helper funcs
>>       - use gdb_test_multiple
>>
>>  gdb/testsuite/config/monitor.exp |   16 +++++++++++++++-
>>  gdb/testsuite/lib/gdb.exp        |   27 +++++++++++++++++++++++++++
>>  2 files changed, 42 insertions(+), 1 deletions(-)
>
> This version is OK.  You forgot to provide a ChangeLog and I forgot
> to remind you about that....

committed with:
2011-06-30 Jie Zhang <jie.zhang@analog.com>
Mike Frysinger <vapier@gentoo.org>

* config/monitor.exp (get_remotetimeout, set_remotetimeout): New
helper functions for getting/setting remotetimeout variable.
* lib/gdb.exp (gdb_load): If the target is remote, set
$oldremotetimeout to get_remotetimeout, then call set_remotetimeout
with $loadtimeout. Set $load_ok to 0 before doing the load.
Instead of returning, immediately, set $load_ok to 0. Call
set_remotetimeout with $oldremotetimeout, and then return if
$load_ok is 1.
-mike