From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32395 invoked by alias); 23 Jun 2011 14:41:15 -0000 Received: (qmail 32387 invoked by uid 22791); 23 Jun 2011 14:41:14 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 23 Jun 2011 14:41:00 +0000 Received: (qmail 17810 invoked from network); 23 Jun 2011 14:40:59 -0000 Received: from unknown (HELO ?192.168.0.101?) (yao@127.0.0.2) by mail.codesourcery.com with ESMTPA; 23 Jun 2011 14:40:59 -0000 Message-ID: <4E035078.5070205@codesourcery.com> Date: Thu, 23 Jun 2011 14:41:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.17) Gecko/20110424 Lightning/1.0b2 Thunderbird/3.1.10 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [patch] XFAIL gdb.cp/mb-inline.exp conditionaly References: <4DF8BEEF.5010308@codesourcery.com> <201106221638.30062.pedro@codesourcery.com> <4E030591.6040709@codesourcery.com> <201106231137.03657.pedro@codesourcery.com> In-Reply-To: <201106231137.03657.pedro@codesourcery.com> Content-Type: multipart/mixed; boundary="------------090702080607020904000406" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00354.txt.bz2 This is a multi-part message in MIME format. --------------090702080607020904000406 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-length: 566 On 06/23/2011 06:37 PM, Pedro Alves wrote: > On Thursday 23 June 2011 10:21:21, Yao Qi wrote: >> gdb/testsuite/ >> * gdb.cp/mb-inline.exp: Parse the output of `info break' to check breakpoint >> 1.2 is disabled. XFAIL for uclinux. > > If you don't want to fix gdb for this now, then please open a PR, and > make it a kfail instead. Okay with that change. > A PR is opened http://sourceware.org/bugzilla/show_bug.cgi?id=12924. Patch attached is what I committed. http://sourceware.org/ml/gdb-cvs/2011-06/msg00139.html -- Yao (齐尧) --------------090702080607020904000406 Content-Type: text/x-patch; name="mb-inline-v2.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="mb-inline-v2.patch" Content-length: 1105 gdb/testsuite/ * gdb.cp/mb-inline.exp: Parse the output of `info break' to check breakpoint 1.2 is disabled. KFAIL for uclinux. diff --git a/gdb/testsuite/gdb.cp/mb-inline.exp b/gdb/testsuite/gdb.cp/mb-inline.exp index 86cb5ba..81f7460 100644 --- a/gdb/testsuite/gdb.cp/mb-inline.exp +++ b/gdb/testsuite/gdb.cp/mb-inline.exp @@ -101,7 +101,19 @@ gdb_expect { } } -gdb_continue_to_end "disabled breakpoint 1.2" +gdb_test_multiple "info break" "disabled breakpoint 1.2" { + -re "1\.2.* n .* at .*$hdrfile:$bp_location.*$gdb_prompt $" { + pass "disabled breakpoint 1.2" + } + -re "1\.2.* y .* at .*$hdrfile:$bp_location.*$gdb_prompt $" { + # When inferior is restarted, breakpoint locations will be updated. + # On uclinux, it is not guaranteed that new inferior is located the + # same address as previous one, so status/state of breakpoint location + # will loose. The heuristic of GDB should be improved. + setup_kfail gdb/12924 "*-*-uclinux*" + fail "disabled breakpoint 1.2" + } +} # Make sure we can set a breakpoint on a source statement that spans # multiple lines. --------------090702080607020904000406--