From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32091 invoked by alias); 23 Jun 2011 09:53:42 -0000 Received: (qmail 32083 invoked by uid 22791); 23 Jun 2011 09:53:42 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mms3.broadcom.com (HELO MMS3.broadcom.com) (216.31.210.19) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 23 Jun 2011 09:53:29 +0000 Received: from [10.9.200.133] by MMS3.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.3.2)); Thu, 23 Jun 2011 02:57:30 -0700 X-Server-Uuid: B55A25B1-5D7D-41F8-BC53-C57E7AD3C201 Received: from mail-irva-13.broadcom.com (10.11.16.103) by IRVEXCHHUB02.corp.ad.broadcom.com (10.9.200.133) with Microsoft SMTP Server id 8.2.247.2; Thu, 23 Jun 2011 02:53:03 -0700 Received: from [10.177.73.61] (unknown [10.177.73.61]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id 284D674D05 for ; Thu, 23 Jun 2011 02:53:13 -0700 (PDT) Message-ID: <4E030D09.9050004@broadcom.com> Date: Thu, 23 Jun 2011 09:53:00 -0000 From: "Andrew Burgess" User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.17) Gecko/20110414 Lightning/1.0b2 Thunderbird/3.1.10 MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: Re: [PATCH] append_composite_type_field_aligned References: <4DF0E83C.8010600@broadcom.com> In-Reply-To: Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00340.txt.bz2 On 22/06/2011 20:54, Tom Tromey wrote: > > Ok with one nit.. > > Andrew> + int left; > Andrew> + alignment *= TARGET_CHAR_BIT; > > Blank line between declarations and code. > Committed with the extra blank line added. Thanks, Andrew