From: Marek Polacek <mpolacek@redhat.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [PATCH] gdb.mi/mi-var-display.exp: fix racy tests (PR testsuite/12649)
Date: Tue, 21 Jun 2011 13:57:00 -0000 [thread overview]
Message-ID: <4E00A31B.6030500@redhat.com> (raw)
Another one where we need to replace gdb_test_multiple with mi_gdb_test
to prevent failures with read1(). Note that when setting `fp', we need
to s/1/3/ since the index 1 and 2 is used by mi_gdb_test. Tested with
both read{,1}. OK to apply?
2011-06-21 Marek Polacek <mpolacek@redhat.com>
* gdb.mi/mi-var-display.exp: Replace gdb_test_multiple with mi_gdb_test.
--- gdb/gdb/testsuite/gdb.mi/mi-var-display.exp.mp 2011-06-21 13:05:15.679575309 +0200
+++ gdb/gdb/testsuite/gdb.mi/mi-var-display.exp 2011-06-21 13:34:06.561961094 +0200
@@ -605,12 +605,8 @@ mi_gdb_test "-var-list-children anone" \
# Record fp
-
-gdb_test_multiple "p/x \$fp" "print FP register" {
- -re ".*($hex).*\\^done\r\n$mi_gdb_prompt$" {
- pass "print FP register"
- set fp $expect_out(1,string)
- }
+if ![mi_gdb_test "p/x \$fp" ".*($hex).*\\^done" "Xprint FP register"] {
+ set fp $expect_out(3,string)
}
mi_continue_to "incr_a"
next reply other threads:[~2011-06-21 13:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 13:57 Marek Polacek [this message]
2011-06-22 11:57 ` Marek Polacek
2011-06-22 16:06 ` Tom Tromey
2011-06-22 16:13 ` Marek Polacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E00A31B.6030500@redhat.com \
--to=mpolacek@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox