From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5856 invoked by alias); 23 Aug 2012 17:02:01 -0000 Received: (qmail 5831 invoked by uid 22791); 23 Aug 2012 17:01:58 -0000 X-SWARE-Spam-Status: No, hits=-2.9 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from server-nat-6.cs.umd.edu (HELO bacon.cs.umd.edu) (128.8.127.149) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 23 Aug 2012 17:01:35 +0000 Received: from wireless-206-196-166-174.umd.edu (wireless-206-196-166-174.umd.edu [206.196.166.174]) (Authenticated sender: khooyp) by bacon.cs.umd.edu (Postfix) with ESMTPSA id 062C9B4027A; Thu, 23 Aug 2012 13:01:32 -0400 (EDT) Subject: Re: Document how to exit "python-interactive" Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Khoo Yit Phang In-Reply-To: <83boi1a72i.fsf@gnu.org> Date: Thu, 23 Aug 2012 17:02:00 -0000 Cc: Khoo Yit Phang , gdb-patches@sourceware.org Content-Transfer-Encoding: quoted-printable Message-Id: <4DE79193-BBBE-46B5-854A-9CB70CC6B4FC@cs.umd.edu> References: <83boi1a72i.fsf@gnu.org> To: Eli Zaretskii X-CSD-MailScanner-ID: 062C9B4027A.AA48B X-CSD-MailScanner: Found to be clean X-CSD-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-50, required 5, autolearn=not spam, ALL_TRUSTED -50.00) X-CSD-MailScanner-From: khooyp@cs.umd.edu X-CSD-MailScanner-Watermark: 1346346093.32061@+1T714RfIVhym/lHVZEP7g Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00677.txt.bz2 Hi, On Aug 23, 2012, at 12:47 PM, Eli Zaretskii wrote: >> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo >> --- a/gdb/doc/gdb.texinfo >> +++ b/gdb/doc/gdb.texinfo >> @@ -22515,7 +22515,8 @@ >> @item python-interactive @r{[}@var{command}@r{]} >> @itemx pi @r{[}@var{command}@r{]} >> Without an argument, the @code{python-interactive} command can be used >> -to start an interactive Python prompt. >> +to start an interactive Python prompt. To return to @value{GDBN}, >> +type @code{EOF} (e.g., @samp{Ctrl-D}) on an empty prompt. >=20 > I think "type the @code{EOF} character" is better. >=20 > Also, please use @kbd{Ctrl-D}. Finally, I think "on the empty prompt" > is redundant (and may even be incorrect -- doesn't it work even on a > non-empty line?). Ctrl-D must be on an empty line to signal EOF, at least on Linux and probab= ly other Unix systems. On Windows, EOF is supposed to be Ctrl-Z followed by= enter, but I don't know if it needs to be on an empty line. I'll move the = "on an empty prompt" into the parentheses to be more accurate. >> python_interactive_command, >> #ifdef HAVE_PYTHON >> _("\ >> -Start a Python interactive prompt.\n\ >> +Start a Python interactive prompt. To return to GDB, type EOF\n\ >=20 > I think the second sentence should begin on a new line. Don't you get > that line truncated in "apropos" output? I hadn't known about "apropos", but the help prints fine since "apropos" ap= pears to print only up to the first period. I'll leave it as is. If it sounds good, I'll make the changes and check it in. Thanks! Yit August 23, 2012