From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27804 invoked by alias); 1 Jun 2011 18:35:41 -0000 Received: (qmail 27633 invoked by uid 22791); 1 Jun 2011 18:35:40 -0000 X-SWARE-Spam-Status: No, hits=-6.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 01 Jun 2011 18:35:18 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p51IZIFg025225 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 1 Jun 2011 14:35:18 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p51IZFpP022931 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 1 Jun 2011 14:35:17 -0400 Message-ID: <4DE68663.7070408@redhat.com> Date: Wed, 01 Jun 2011 18:35:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc13 Lightning/1.0b3pre Thunderbird/3.1.10 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [rfc 2/2] Follow DW_AT_linkage_name for methods [Re: The future of dwarf2_physname] References: <4DD44983.7060406@redhat.com> <20110523131659.GA30344@host1.jankratochvil.net> <20110524212111.GB7747@host1.jankratochvil.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00012.txt.bz2 On 05/25/2011 01:40 PM, Tom Tromey wrote: >>>>>> "Jan" == Jan Kratochvil writes: > > Jan> Also after a chat with Tom Tromey I no longer use DMGL_RET_POSTFIX. > Jan> That is for ELF symbol `long m()' GDB with proposed patch > Jan> uses `m()' (and not `m()long'). This is compatible > Jan> with gdb-7.2 (physname) template functions. > > This patch looks pretty good to me. > > Keith, are there parts of your series which are still needed for 7.3 if > this patch is committed there? If we want to fix 12266, yes, we're still going to need much of the patchset: cp_canonicalize_no_typedefs, printname, and the cp_demangled_name_parse_free patches. Those patches fix 12266 and a bunch of related problems (which are not regressions): *** Using pre-physname: (gdb) b calltest(foo) Function "calltest(foo)" not defined. Make breakpoint pending on future shared library load? (y or [n]) n (gdb) b calltest(std::string) Breakpoint 1 at 0x40075c: file 12266.cc, line 5. (gdb) b calltest(std::basic_string, std::allocator >) Function "calltest(std::basic_string, std::allocator >)" not defined. Make breakpoint pending on future shared library load? (y or [n]) n *** Using DW_AT_linkage_name (Jan's patches): (gdb) b calltest(foo) Function "calltest(foo)" not defined. Make breakpoint pending on future shared library load? (y or [n]) n (gdb) b calltest(std::string) Function "calltest(std::string)" not defined. Make breakpoint pending on future shared library load? (y or [n]) n (gdb) b calltest(std::basic_string, std::allocator >) Breakpoint 1 at 0x40075c: file 12266.cc, line 5. *** Using 12266 patches (on top of Jan's DW_AT_linkage_name patches): (gdb) b calltest(foo) Breakpoint 1 at 0x40075c: file 12266.cc, line 5. (gdb) b calltest(std::string) Note: breakpoint 1 also set at pc 0x40075c. Breakpoint 2 at 0x40075c: file 12266.cc, line 5. (gdb) b calltest(std::basic_string, std::allocator >) Note: breakpoints 1 and 2 also set at pc 0x40075c. Breakpoint 3 at 0x40075c: file 12266.cc, line 5. Mind you, I don't know if I would recommend taking in such a big patch this late in the game... Nonetheless, I hope to have this resubmitted today. Keith