From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25500 invoked by alias); 26 May 2011 20:10:33 -0000 Received: (qmail 25443 invoked by uid 22791); 26 May 2011 20:10:18 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 May 2011 20:09:58 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4QK9jFB015420 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 26 May 2011 16:09:45 -0400 Received: from dhcp-25-89.brq.redhat.com (pdp-11.brq.redhat.com [10.34.24.63]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p4QK9hqh002951; Thu, 26 May 2011 16:09:44 -0400 Message-ID: <4DDEB387.3000509@redhat.com> Date: Thu, 26 May 2011 20:10:00 -0000 From: Marek Polacek User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100827 Red Hat Thunderbird/3.1.3 MIME-Version: 1.0 To: Mike Frysinger CC: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org Subject: Re: [PATCH] gdb: sim: automatically pass down sysroot References: <1306440200-25087-1-git-send-email-vapier@gentoo.org> In-Reply-To: <1306440200-25087-1-git-send-email-vapier@gentoo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00622.txt.bz2 On 05/26/2011 10:03 PM, Mike Frysinger wrote: > + /* Pass along gdb's concept of the sysroot. */ > + strcat (arg_buf, " --sysroot="); > + strcat (arg_buf, gdb_sysroot); BTW, couldn't be those strcat()s replaced by, e.g., cheaper mempcpy()? Marek