From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13400 invoked by alias); 20 May 2011 15:22:50 -0000 Received: (qmail 13385 invoked by uid 22791); 20 May 2011 15:22:48 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_RMML_Stock9,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 20 May 2011 15:22:32 +0000 Received: (qmail 10747 invoked from network); 20 May 2011 15:22:31 -0000 Received: from unknown (HELO ?192.168.0.102?) (yao@127.0.0.2) by mail.codesourcery.com with ESMTPA; 20 May 2011 15:22:31 -0000 Message-ID: <4DD68727.3040502@codesourcery.com> Date: Fri, 20 May 2011 15:22:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.14) Gecko/20110223 Lightning/1.0b2 Thunderbird/3.1.8 MIME-Version: 1.0 To: "Joseph S. Myers" CC: gdb-patches@sourceware.org Subject: Re: [_Complex test 2/4] _Complex type in varargs.exp References: <4DC401D0.1050500@codesourcery.com> <4DC75036.4040806@codesourcery.com> <4DD49DA6.6040407@codesourcery.com> <4DD51E40.6080401@codesourcery.com> In-Reply-To: Content-Type: multipart/mixed; boundary="------------040401080809080908010405" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00481.txt.bz2 This is a multi-part message in MIME format. --------------040401080809080908010405 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-length: 2078 On 05/19/2011 11:27 PM, Joseph S. Myers wrote: > On Thu, 19 May 2011, Yao Qi wrote: > >> Tests in this case also fail on armv7l-unknown-linux-gnueabi and >> x86_64-unknown-linux-gnu. Shall I have to file yet another two PRs for >> armv7l-unknown-linux-gnueabi and x86_64-unknown-linux-gnu respectively, >> and KFAIL them to different PR separately? At least, I didn't see such >> usage elsewhere in gdb testsuite. > > I think the correct division is one PR per target architecture for all > complex types ABI issues, rather than one PR per test failure. That's the > only way a target maintainer can sensibly fix their target's problems, > test that they are fixed, and close the relevant PR; otherwise you have a > catch-all bug that's open for ever without meaningfully reflecting what > actually needs to be done to fix the problem. OK, I opened another two PRs for armv7l-unknown-linux-gnueabi and x86_64-unknown-linux-gnu. KFAIL to different PRs according to the target. An internal error on x86_64-linux is not KFAIL'ed, because I failed to KFAIL it after some experiments for some time. x86_64-unknown-linux-gnu: KFAIL: gdb.base/varargs.exp: print find_max_float_real(4, fc1, fc2, fc3, fc4) (PRMS: gdb/12790) KFAIL: gdb.base/varargs.exp: print find_max_double_real(4, dc1, dc2, dc3, dc4) (PRMS: gdb/12790) FAIL: gdb.base/varargs.exp: print find_max_long_double_real(4, ldc1, ldc2, ldc3, ldc4) (GDB internal error) armv7l-unknown-linux-gnueabi: KFAIL: gdb.base/varargs.exp: print find_max_float_real(4, fc1, fc2, fc3, fc4) (PRMS: gdb/12791) KFAIL: gdb.base/varargs.exp: print find_max_double_real(4, dc1, dc2, dc3, dc4) (PRMS: gdb/12791) KFAIL: gdb.base/varargs.exp: print find_max_long_double_real(4, ldc1, ldc2, ldc3, ldc4) (PRMS: gdb/12791) i686-pc-linux-gnu: KFAIL: gdb.base/varargs.exp: print find_max_double_real(4, dc1, dc2, dc3, dc4) (PRMS: gdb/12776) KFAIL: gdb.base/varargs.exp: print find_max_long_double_real(4, ldc1, ldc2, ldc3, ldc4) (PRMS: gdb/12776) If this patch is acceptable, I'll do the similar changes in patch 4/4. -- Yao (齐尧) --------------040401080809080908010405 Content-Type: text/x-patch; name="0002-vararg-of-type-_Complex.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0002-vararg-of-type-_Complex.patch" Content-length: 4742 >From 66ec9759f8595d3f998ed612a1bf6e79be85fc6e Mon Sep 17 00:00:00 2001 From: Yao Qi Date: Wed, 18 May 2011 15:35:31 +0800 Subject: [PATCH 2/4] vararg of type _Complex gdb/testsuite/ Test inf-call of varargs of type _Complex. * gdb.base/varargs.c (find_max_float_real): New. (find_max_double_real, find_max_long_double_real): New. * gdb.base/varargs.exp: Call these new added functions. --- gdb/testsuite/gdb.base/varargs.c | 80 ++++++++++++++++++++++++++++++++++++ gdb/testsuite/gdb.base/varargs.exp | 62 ++++++++++++++++++++++++++++ 2 files changed, 142 insertions(+), 0 deletions(-) diff --git a/gdb/testsuite/gdb.base/varargs.c b/gdb/testsuite/gdb.base/varargs.c index 1122767..1ad2ffc 100644 --- a/gdb/testsuite/gdb.base/varargs.c +++ b/gdb/testsuite/gdb.base/varargs.c @@ -23,6 +23,28 @@ float fa,fb,fc,fd; double da,db,dc,dd; double dmax_val; +#ifdef TEST_COMPLEX +extern float crealf (float _Complex); +extern double creal (double _Complex); +extern long double creall (long double _Complex); + +float _Complex fc1 = 1.0F + 1.0iF; +float _Complex fc2 = 2.0F + 2.0iF; +float _Complex fc3 = 3.0F + 3.0iF; +float _Complex fc4 = 4.0F + 4.0iF; + +double _Complex dc1 = 1.0 + 1.0i; +double _Complex dc2 = 2.0 + 2.0i; +double _Complex dc3 = 3.0 + 3.0i; +double _Complex dc4 = 4.0 + 4.0i; + +long double _Complex ldc1 = 1.0L + 1.0Li; +long double _Complex ldc2 = 2.0L + 2.0Li; +long double _Complex ldc3 = 3.0L + 3.0Li; +long double _Complex ldc4 = 4.0L + 4.0Li; + +#endif + int main() { c = -1; uc = 1; @@ -109,3 +131,61 @@ double find_max_double(int num_vals, double first_val, ...) { return max_val; } + +#ifdef TEST_COMPLEX +float _Complex +find_max_float_real (int num_vals, ...) +{ + float _Complex max = 0.0F + 0.0iF; + float _Complex x; + va_list argp; + int i; + + va_start(argp, num_vals); + for (i = 0; i < num_vals; i++) + { + x = va_arg (argp, float _Complex); + if (crealf (max) < crealf (x)) max = x; + } + + return max; +} + +double _Complex +find_max_double_real (int num_vals, ...) +{ + double _Complex max = 0.0 + 0.0i; + double _Complex x; + va_list argp; + int i; + + va_start(argp, num_vals); + for (i = 0; i < num_vals; i++) + { + x = va_arg (argp, double _Complex); + if (creal (max) < creal (x)) max = x; + } + + return max; +} + +long double _Complex +find_max_long_double_real (int num_vals, ...) +{ + long double _Complex max = 0.0L + 0.0iL; + long double _Complex x; + va_list argp; + int i; + + va_start(argp, num_vals); + for (i = 0; i < num_vals; i++) + { + x = va_arg (argp, long double _Complex); + if (creall (max) < creal (x)) max = x; + } + + return max; +} + + +#endif /* TEST_COMPLEX */ diff --git a/gdb/testsuite/gdb.base/varargs.exp b/gdb/testsuite/gdb.base/varargs.exp index 4627862..c556bff 100644 --- a/gdb/testsuite/gdb.base/varargs.exp +++ b/gdb/testsuite/gdb.base/varargs.exp @@ -44,6 +44,9 @@ if [get_compiler_info ${binfile}] { } set additional_flags {debug} +if [support_complex_tests] { + lappend additional_flags "additional_flags=-DTEST_COMPLEX" +} if {$hp_cc_compiler} { lappend additional_flags "additional_flags=-Ae" @@ -112,3 +115,62 @@ if {![target_info exists gdb,skip_float_tests]} { "print find_max_double(5,1.0,17.0,2.0,3.0,4.0)" } + +# Test _Complex type here if supported. +if [support_complex_tests] { + global gdb_prompt + + set test "print find_max_float_real(4, fc1, fc2, fc3, fc4)" + gdb_test_multiple $test $test { + -re ".*= 4 \\+ 4 \\* I.*${gdb_prompt} $" { + pass $test + } + -re ".*$gdb_prompt $" { + if {[istarget "x86_64-*-*"]} { + kfail gdb/12790 $test + } elseif {[istarget "arm*-*-*"]} { + kfail gdb/12791 $test + } else { + fail $test + } + } + } + + set test "print find_max_double_real(4, dc1, dc2, dc3, dc4)" + gdb_test_multiple $test $test { + -re ".*= 4 \\+ 4 \\* I.*${gdb_prompt} $" { + pass $test + } + -re ".*$gdb_prompt $" { + if {[istarget "i?86-*-*"]} { + kfail gdb/12776 $test + } elseif {[istarget "x86_64-*-*"]} { + kfail gdb/12790 $test + } elseif {[istarget "arm*-*-*"]} { + kfail gdb/12791 $test + } else { + fail $test + } + } + } + + set test "print find_max_long_double_real(4, ldc1, ldc2, ldc3, ldc4)" + gdb_test_multiple $test $test { + -re ".*= 4 \\+ 4 \\* I.*${gdb_prompt} $" { + pass $test + } + -re ".*$gdb_prompt $" { + if {[istarget "i?86-*-*"]} { + kfail gdb/12776 $test + } elseif {[istarget "x86_64-*-*"]} { + kfail gdb/12790 $test + } elseif {[istarget "arm*-*-*"]} { + kfail gdb/12791 $test + } else { + fail $test + } + } + + } + +} -- 1.7.0.4 --------------040401080809080908010405--