On 05/19/2011 11:27 PM, Joseph S. Myers wrote: > On Thu, 19 May 2011, Yao Qi wrote: > >> Tests in this case also fail on armv7l-unknown-linux-gnueabi and >> x86_64-unknown-linux-gnu. Shall I have to file yet another two PRs for >> armv7l-unknown-linux-gnueabi and x86_64-unknown-linux-gnu respectively, >> and KFAIL them to different PR separately? At least, I didn't see such >> usage elsewhere in gdb testsuite. > > I think the correct division is one PR per target architecture for all > complex types ABI issues, rather than one PR per test failure. That's the > only way a target maintainer can sensibly fix their target's problems, > test that they are fixed, and close the relevant PR; otherwise you have a > catch-all bug that's open for ever without meaningfully reflecting what > actually needs to be done to fix the problem. OK, I opened another two PRs for armv7l-unknown-linux-gnueabi and x86_64-unknown-linux-gnu. KFAIL to different PRs according to the target. An internal error on x86_64-linux is not KFAIL'ed, because I failed to KFAIL it after some experiments for some time. x86_64-unknown-linux-gnu: KFAIL: gdb.base/varargs.exp: print find_max_float_real(4, fc1, fc2, fc3, fc4) (PRMS: gdb/12790) KFAIL: gdb.base/varargs.exp: print find_max_double_real(4, dc1, dc2, dc3, dc4) (PRMS: gdb/12790) FAIL: gdb.base/varargs.exp: print find_max_long_double_real(4, ldc1, ldc2, ldc3, ldc4) (GDB internal error) armv7l-unknown-linux-gnueabi: KFAIL: gdb.base/varargs.exp: print find_max_float_real(4, fc1, fc2, fc3, fc4) (PRMS: gdb/12791) KFAIL: gdb.base/varargs.exp: print find_max_double_real(4, dc1, dc2, dc3, dc4) (PRMS: gdb/12791) KFAIL: gdb.base/varargs.exp: print find_max_long_double_real(4, ldc1, ldc2, ldc3, ldc4) (PRMS: gdb/12791) i686-pc-linux-gnu: KFAIL: gdb.base/varargs.exp: print find_max_double_real(4, dc1, dc2, dc3, dc4) (PRMS: gdb/12776) KFAIL: gdb.base/varargs.exp: print find_max_long_double_real(4, ldc1, ldc2, ldc3, ldc4) (PRMS: gdb/12776) If this patch is acceptable, I'll do the similar changes in patch 4/4. -- Yao (齐尧)