From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16290 invoked by alias); 19 May 2011 13:01:50 -0000 Received: (qmail 16276 invoked by uid 22791); 19 May 2011 13:01:49 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 May 2011 13:01:35 +0000 Received: (qmail 21350 invoked from network); 19 May 2011 13:01:35 -0000 Received: from unknown (HELO ?192.168.0.102?) (yao@127.0.0.2) by mail.codesourcery.com with ESMTPA; 19 May 2011 13:01:35 -0000 Message-ID: <4DD514A6.7040606@codesourcery.com> Date: Thu, 19 May 2011 13:01:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.14) Gecko/20110223 Lightning/1.0b2 Thunderbird/3.1.8 MIME-Version: 1.0 To: Mark Kettenis CC: gdb-patches@sourceware.org Subject: Re: [_Complex test 1/4] support_complex_tests in gdb.exp and pass _Complex args to func References: <4DC401D0.1050500@codesourcery.com> <4DC75036.4040806@codesourcery.com> <4DD49BE7.80206@codesourcery.com> <201105190814.p4J8EMYF020774@glazunov.sibelius.xs4all.nl> In-Reply-To: <201105190814.p4J8EMYF020774@glazunov.sibelius.xs4all.nl> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00435.txt.bz2 On 05/19/2011 04:14 PM, Mark Kettenis wrote: > The other thing is that the testsuite should not be "conservative". > We should run as many tests as possible on as many platforms as > possible. Tests that are known to fail should be KFAILed (if there is > a known bug/issue with GDB itself) or XFAILed (if there is an issue > with the platform). Only if running the tests causes serious problems > (crashing the OS, causing excessive timeouts) we should consider > skipping them. No. I don't want to break running non-complex-type tests in funcargs.exp or varargs.exp on platforms that don't support _Complex after this patch. -- Yao (齐尧)