Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Marek Polacek <mpolacek@redhat.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [PATCH] gdb.mi/mi-nonstop.exp: fix racy tests (PR testsuite/12649)
Date: Thu, 19 May 2011 10:41:00 -0000	[thread overview]
Message-ID: <4DD4F3B7.2070003@redhat.com> (raw)

In this test, there were three occurrences of the gdb_tes_multiple.  All
of them are of course causing races.  

The first case is exactly the same as in `mi-nonstop-exit.exp'.

The second test case cannot be, I think, converted to mi_gdb_test :(.  It is
because mi_gdb_test automatically appends `\[\r\n\]+$mi_gdb_prompt', but in
this particular case, we don't want this, since we expect the following
(no prompt at the end, instead, prompt is in the middle):

-exec-interrupt --thread 1
^done
(gdb) 
*stopped,reason="signal-received",signal-name="0",signal-meaning="...

And the third case could be, fortunately, converted into mi_gdb_test.

Tested with both read{,1}.  Ok?  

2011-05-19  Marek Polacek  <mpolacek@redhat.com>

        * gdb.mi/mi-nonstop.exp: Use the send_gdb+gdb_expect or mi_gdb_test
        instead of the gdb_test_multiple.

--- gdb/gdb/testsuite/gdb.mi/mi-nonstop.exp.mp	2011-01-01 16:33:47.000000000 +0100
+++ gdb/gdb/testsuite/gdb.mi/mi-nonstop.exp	2011-05-19 12:33:22.038216967 +0200
@@ -47,13 +47,17 @@ mi_gdb_reinitialize_dir $srcdir/$subdir
 mi_gdb_load $binfile
 
 set supported 0
-gdb_test_multiple "-gdb-show non-stop" "" {
-    -re ".*\\^done,value=\"off\",supported=\"(\[^\"\]+)\"\r\n$mi_gdb_prompt$" {
+send_gdb "-gdb-show non-stop\n"
+gdb_expect {
+    -re "\\^done,value=\"off\",supported=\"(\[^\"\]+)\"\r\n$mi_gdb_prompt$" {
 	if { $expect_out(1,string) == "1" } {
 	    set supported 1
 	}
     }
+    -re "\\^done,value=\"off\"\r\n$mi_gdb_prompt$" {
+    }
     -re ".*$mi_gdb_prompt$" {
+	fail "-gdb-show non-stop"
     }
 }
 
@@ -92,22 +96,21 @@ mi_varobj_update * {I_W1 I_W0} "update v
 mi_check_varobj_value I_W0 1 "check varobj, w0, 1"
 mi_check_varobj_value I_W1 1 "check varobj, w1, 1"
 
-gdb_test_multiple "-exec-interrupt --thread 1" "interrupted" {
+send_gdb "-exec-interrupt --thread 1\n"
+gdb_expect {
     -re "\\^done\r\n$mi_gdb_prompt\\*stopped\[^\r\n\]+\r\n$" {
 	pass "interrupted"
     }
 }
+
 # The interrupt command sends SIGINT to the target, and therefore the
 # thread might not be stopped immediately when we return from the target.
 # So, wait a bit
 sleep 1
 mi_check_thread_states {"stopped" "stopped" "stopped"} "thread state, stop 4"
 
-gdb_test_multiple "-exec-continue --all" "resume all" {
-    -re ".*\\*running,thread-id=\"3\"\r\n\\*running,thread-id=\"2\"\r\n\\*running,thread-id=\"1\"\r\n$mi_gdb_prompt" {
-	pass "resume all"
-    }
-}
+mi_gdb_test "-exec-continue --all" ".*\\*running,thread-id=\"3\"\r\n\\*running,thread-id=\"2\"\r\n\\*running,thread-id=\"1\"" \
+    "resume all"
 
 mi_expect_stop "breakpoint-hit" "break_at_me" "\[^\n\]*" "non-stop.c" "\[0-9\]*" {"" "disp=\"keep\""} "w0,i2 stop"
 mi_expect_stop "breakpoint-hit" "break_at_me" ".*" "non-stop.c" ".*" {"" "disp=\"keep\""} "w1,i2 stop"


             reply	other threads:[~2011-05-19 10:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-19 10:41 Marek Polacek [this message]
2011-05-26 16:24 ` Tom Tromey
2011-05-26 16:32   ` Pedro Alves
2011-05-27 11:20     ` Marek Polacek
2011-05-27 11:46       ` Marek Polacek
2011-05-27 12:08         ` Pedro Alves
2011-05-27 12:49           ` Marek Polacek
2011-05-27 17:55             ` Tom Tromey
2011-05-27 17:56               ` Marek Polacek
2011-05-27 14:07     ` Marek Polacek
2011-05-27 14:14       ` Pedro Alves
2011-05-27 14:18         ` Marek Polacek
2011-05-27 10:58   ` Marek Polacek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DD4F3B7.2070003@redhat.com \
    --to=mpolacek@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox