From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16187 invoked by alias); 6 May 2011 08:58:43 -0000 Received: (qmail 16175 invoked by uid 22791); 6 May 2011 08:58:41 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 06 May 2011 08:58:23 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p468wN6P030808 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 6 May 2011 04:58:23 -0400 Received: from dhcp-25-89.brq.redhat.com (pdp-11.brq.redhat.com [10.34.24.63]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p468wMGw030628; Fri, 6 May 2011 04:58:22 -0400 Message-ID: <4DC3B82D.1000505@redhat.com> Date: Fri, 06 May 2011 08:58:00 -0000 From: Marek Polacek User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100827 Red Hat Thunderbird/3.1.3 MIME-Version: 1.0 To: Jan Kratochvil CC: "gdb-patches@sourceware.org" Subject: Re: [RFC] gdb.cp/static-print-quit.exp: fix racy tests (PR testsuite/12649) References: <20110506021511.GA30222@host1.jankratochvil.net> In-Reply-To: <20110506021511.GA30222@host1.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00178.txt.bz2 On 05/06/2011 04:15 AM, Jan Kratochvil wrote: > exp_continue/variables make it complicated, I would prefer splitting it to > multiple consecutive test cases. Yep, splitting the case was apparently the right thing to do. What a shame that this didn't occurred to me before. Thanks. > BTW you do not need to match exactly "" as is in lib/gdb.exp - it is > enough to match any string ending with "". OK, I wish I knew this before :-). > FYI the diff could not be applied as it has s converted to spaces. Right, sorry. > Any comments? I will check it in otherwise. I tested your patch and all seems fine. Maybe just, I think here: > +set test "print c - q " > +gdb_test_multiple "" $test { > + -re " to continue, or q " { and here: > +set test "print c - to quit" > +gdb_test_multiple "" $test { > -re " to quit---$" { the `-re' are in fact not needed since we don't use any regexps in the string. However, they certainly do no harm so no need to remove them. Thanks again, Jan. Marek