From: Kwok Cheung Yeung <kcy@codesourcery.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Support for enabling/disabling tracepoints while a trace experiment is running
Date: Thu, 05 May 2011 18:29:00 -0000 [thread overview]
Message-ID: <4DC2EC8E.6080401@codesourcery.com> (raw)
In-Reply-To: <201105051848.15560.pedro@codesourcery.com>
On 05/05/2011 18:48, Pedro Alves wrote:
>> + if ((enable && tp->enabled) || (!enable && !tp->enabled))
>
> but isn't this just:
>
> if (enable != tp->enabled)
>
> ?
>
In this case it is, since enable and tp->enabled can only take the values 0 and
1. However, 'true' in C is 'non-zero' - 1 and ~0 are both non-zero and therefore
'true', but they aren't equal. The first version would get the boolean
comparison correct if there were multiple values of 'true' being used, whereas
the second would not.
Kwok
next prev parent reply other threads:[~2011-05-05 18:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 17:27 Kwok Cheung Yeung
2011-05-05 17:48 ` Pedro Alves
2011-05-05 18:29 ` Kwok Cheung Yeung [this message]
2011-05-05 18:52 ` Eli Zaretskii
2011-05-05 23:13 ` Kwok Cheung Yeung
2011-05-05 23:47 ` Stan Shebs
2011-05-06 10:33 ` Eli Zaretskii
2011-05-09 19:31 ` Kwok Cheung Yeung
2011-05-09 19:35 ` Eli Zaretskii
2011-05-11 9:14 ` Pedro Alves
2011-05-06 17:42 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC2EC8E.6080401@codesourcery.com \
--to=kcy@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox