From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21528 invoked by alias); 3 May 2011 18:05:07 -0000 Received: (qmail 21516 invoked by uid 22791); 3 May 2011 18:05:06 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 03 May 2011 18:04:50 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p43I4gPO017575 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 3 May 2011 14:04:42 -0400 Received: from dhcp-25-89.brq.redhat.com (pdp-11.brq.redhat.com [10.34.24.63]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p43I4fjV003439; Tue, 3 May 2011 14:04:42 -0400 Message-ID: <4DC043B9.6040403@redhat.com> Date: Tue, 03 May 2011 18:05:00 -0000 From: Marek Polacek User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100827 Red Hat Thunderbird/3.1.3 MIME-Version: 1.0 To: Pedro Alves CC: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb.base/pr10179.exp: fix racy tests (PR testsuite/12649) References: <4DBEE73B.3040202@redhat.com> <201105022024.01156.pedro@codesourcery.com> <4DC032F1.3030705@redhat.com> <201105031850.46894.pedro@codesourcery.com> In-Reply-To: <201105031850.46894.pedro@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00072.txt.bz2 On 05/03/2011 07:50 PM, Pedro Alves wrote: > You're assuming I already knew the fail was of "interactive prompt" > kind. :-) I didn't, but I now ran the test and see the failure. Seeing > this also helps review: > > FAIL: gdb.base/pr10179.exp: delete breakpoints (got interactive prompt) > FAIL: gdb.base/pr10179.exp: rbreak pr10179-a.c:foo.* > FAIL: gdb.base/pr10179.exp: rbreak pr10179-a.c : .* (got interactive prompt) > > Knowing all this, your original patch was indeed trivial. Yeah, I should have shown this before. Next time, I will. > Okay, thanks, this is even better. Applied: http://sourceware.org/ml/gdb-cvs/2011-05/msg00019.html Thank you. Marek