Re: [PATCH] gdb.base/pr10179.exp: fix racy tests (PR testsuite/12649)

Marek Polacek
2011-05-03T16:53:40Z

On 05/02/2011 09:24 PM, Pedro Alves wrote:
> Please, can you try again, with some explanation of _why_ is
> it needed to ...

You are right, I'm sorry. Thus, here is another try.

> For instance, break.exp doesn't appear to
> need to match the whole question.

In break.exp, there are no `gdb_test "delete breakpoints"'.

> Not sure the original PR 10179 had something to do with
> deleting breakpoints, otherwise, there's a delete_breakpoints
> procedure tests can use to do this.

I think the best thing here is to make use of the `delete_breakpoints', since
pr10179.exp addresses to test the `rbreak', not deleting the breakpoints.
Replacing `gdb_test "delete breakpoints"' with delete_breakpoints also
cures the races. IIUC, the race was caused by this part:

"Delete all breakpoints.*" "y"

Thus, when using read1(), we match the question "Delete all breakpoints?
(y or n)" right after the "breakpoints" word. This will leave in the buffer
"? (y or n)". The "(y or n)" matches and causes the "interactive prompt" fail.

Here is a better patch. Tested with both read{,1}. OK now? Thanks,

2011-05-03 Marek Polacek <mpolacek@redhat.com>

* gdb.base/pr10179.exp: Get rid of races using `delete_breakpoints'
in place of `gdb_test "delete breakpoints"'. This eliminates two
testcases.

Index: pr10179.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/pr10179.exp,v
retrieving revision 1.2
diff -u -r1.2 pr10179.exp
--- pr10179.exp 1 Jan 2011 15:33:42 -0000 1.2
+++ pr10179.exp 3 May 2011 16:46:27 -0000
@@ -29,10 +29,10 @@

gdb_test "rbreak foo.*" "Breakpoint \[0-9\]+\[^\\n\]*\\nint foo\[12\]\[^\\n\]*\\nBreakpoint \[0-9\]+\[^\\n\]*\\nint foo\[12\].*"

-gdb_test "delete breakpoints" ".*" "" "Delete all breakpoints.*" "y"
+delete_breakpoints

gdb_test "rbreak pr10179-a.c:foo.*" "Breakpoint \[0-9\]+\[^\\n\]*\\nint foo.*"

-gdb_test "delete breakpoints" ".*" "" "Delete all breakpoints.*" "y"
+delete_breakpoints

gdb_test "rbreak pr10179-a.c : .*" "Breakpoint \[0-9\]+\[^\\n\]*\\nint bar1\[^\\n\]*\\nBreakpoint \[0-9\]+\[^\\n\]*\\nint foo1\[^\\n\]*\\nBreakpoint \[0-9\]+\[^\\n\]*\\nint main\[^\\n\]*.*"