Re: [PATCH] gdb.base/pr10179.exp: fix racy tests (PR testsuite/12649)

Pedro Alves
2011-05-02T19:24:17Z

On Monday 02 May 2011 18:17:47, Marek Polacek wrote:
> This one is quite trivial.

Probably. But, it most probably only became trivial/obvious to you
after looking at the gdb.log around the FAIL, and noticing, "ahh,
the race is because FOO, and BAR". If you don't explain those FOOs
and BARs on your patch submission, whoever reviews the patch needs
to do about the same analysis work you've done.
Please, can you try again, with some explanation of _why_ is
it needed to ...

> It was needed to write the whole
> question instead of using the `.*' at the end. I have also
> added the message input.

... do these? For instance, break.exp doesn't appear to
need to match the whole question.

Not sure the original PR 10179 had something to do with
deleting breakpoints, otherwise, there's a delete_breakpoints
procedure tests can use to do this.

I'm not objecting or approving in any way, and it's really
probably trivial. Just trying to point out that if you make it
easier to okay your patches, you'll get okay's much quicker. :-)

> Ok?
>
> 2011-05-02 Marek Polacek <mpolacek@redhat.com>
>
> * gdb.base/pr10179.exp: Fix racy tests by completing
> the question properly. Also provide the message input.
>
>
> Index: gdb/testsuite/gdb.base/pr10179.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/pr10179.exp,v
> retrieving revision 1.2
> diff -u -r1.2 pr10179.exp
> --- gdb/testsuite/gdb.base/pr10179.exp 1 Jan 2011 15:33:42 -0000 1.2
> +++ gdb/testsuite/gdb.base/pr10179.exp 2 May 2011 17:09:34 -0000
> @@ -29,10 +29,10 @@
>
> gdb_test "rbreak foo.*" "Breakpoint \[0-9\]+\[^\\n\]*\\nint foo\[12\]\[^\\n\]*\\nBreakpoint \[0-9\]+\[^\\n\]*\\nint foo\[12\].*"
>
> -gdb_test "delete breakpoints" ".*" "" "Delete all breakpoints.*" "y"
> +gdb_test "delete breakpoints" "" "delete breakpoints" "Delete all breakpoints\\? \\(y or n\\) " "y"
>
> gdb_test "rbreak pr10179-a.c:foo.*" "Breakpoint \[0-9\]+\[^\\n\]*\\nint foo.*"
>
> -gdb_test "delete breakpoints" ".*" "" "Delete all breakpoints.*" "y"
> +gdb_test "delete breakpoints" "" "delete breakpoints" "Delete all breakpoints\\? \\(y or n\\) " "y"
>
> gdb_test "rbreak pr10179-a.c : .*" "Breakpoint \[0-9\]+\[^\\n\]*\\nint bar1\[^\\n\]*\\nBreakpoint \[0-9\]+\[^\\n\]*\\nint foo1\[^\\n\]*\\nBreakpoint \[0-9\]+\[^\\n\]*\\nint main\[^\\n\]*.*"
>

--
Pedro Alves