From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16911 invoked by alias); 28 Apr 2011 05:05:50 -0000 Received: (qmail 16901 invoked by uid 22791); 28 Apr 2011 05:05:49 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 28 Apr 2011 05:05:34 +0000 Received: (qmail 5868 invoked from network); 28 Apr 2011 05:05:33 -0000 Received: from unknown (HELO ?192.168.0.102?) (yao@127.0.0.2) by mail.codesourcery.com with ESMTPA; 28 Apr 2011 05:05:33 -0000 Message-ID: <4DB8F597.8060106@codesourcery.com> Date: Thu, 28 Apr 2011 05:05:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.14) Gecko/20110223 Lightning/1.0b2 Thunderbird/3.1.8 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [try 2nd 2/8] Rename copy_* functions to arm_copy_* References: <201104271332.p3RDWUYw011310@d06av02.portsmouth.uk.ibm.com> In-Reply-To: <201104271332.p3RDWUYw011310@d06av02.portsmouth.uk.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00534.txt.bz2 On 04/27/2011 09:32 PM, Ulrich Weigand wrote: > Yao Qi wrote: > >> gdb/ >> * arm-tdep.c (copy_unmodified): Rename to ... >> (arm_copy_unmodified): .. this. New. >> (copy_preload): Move common part to ... >> (install_preload): .. this. New. >> (arm_copy_preload): New. >> (copy_preload_reg): Move common part to ... >> (install_preload_reg): ... this. New. >> (arm_copy_preload_reg): New. >> (copy_b_bl_blx): Move common part to ... >> (install_b_bl_blx): .. this. New. >> (arm_copy_b_bl_blx): New. >> (copy_bx_blx_reg): Move common part to ... >> (install_bx_blx_reg): ... this. New. >> (arm_copy_bx_blx_reg): New. >> (copy_alu_reg): Move common part to ... >> (install_alu_reg): ... this. New. >> (arm_copy_alu_reg): New. >> (copy_alu_shifted_reg): Move common part to ... >> (install_alu_shifted_reg): ... this. New. >> (copy_ldr_str_ldrb_strb): Move common part to ... >> (install_ldr_str_ldrb_strb): ... this. New. >> (arm_copy_ldr_str_ldrb_strb): New. >> (copy_copro_load_store): Move some common part to ... >> (install_copy_copro_load_store): ... this. New. >> (arm_copy_copro_load_store): New. >> (copy_svc): Delete. >> (arm_copy_svc): Renamed from copy_svc. >> (copy_undef): Delete. >> (arm_copy_undef): Renamed from copy_undef. >> (decode_ext_reg_ld_st): Delete. >> (arm_decode_ext_reg_ld_st): Renamed from decode_ext_reg_ld_st. >> (decode_svc_copro): Delete. >> (arm_decode_svc_copro): Renamed from decode_svc_copro. >> (copy_copro_load_store, copy_alu_imm): update callers. >> (copy_extra_ld_st, copy_block_xfer): Likewise. >> (decode_misc_memhint_neon, decode_unconditional): Likewise. >> (decode_miscellaneous, decode_dp_misc): Likewise. >> (decode_ld_st_word_ubyte, decode_media): Likewise. >> (decode_b_bl_ldmstm, decode_ext_reg_ld_st): Likewise. >> (decode_svc_copro, decode_misc_memhint_neon): Likewise. >> (decode_unconditional, decode_miscellaneous): Likewise. >> (decode_media, decode_b_bl_ldmstm): Likewise. >> (arm_process_displaced_insn): Likewise.. >> (decode_misc_memhint_neon): Delete. >> (arm_decode_misc_memhint_neon): Renamed from decode_misc_memhint_neon. >> (decode_miscellaneous): Delete. >> (arm_decode_miscellaneous): Renamed from decode_miscellaneous. >> (decode_dp_misc): Delete. >> (arm_decode_dp_misc): Renamed from decode_dp_misc. >> (decode_ld_st_word_ubyte): Delete. >> (arm_decode_ld_st_word_ubyte): Renamed from decode_ld_st_word_ubyte. >> (decode_media): Delete. >> (arm_decode_media): Renamed from decode_media. >> (decode_b_bl_ldmstm): Delete. >> (arm_decode_b_bl_ldmstm): Renamed from decode_b_bl_ldmstm. >> (decode_ext_reg_ld_st): Delete. >> (arm_decode_ext_reg_ld_st): Renamed from decode_ext_reg_ld_st. >> (decode_unconditional): Delete. >> (arm_decode_unconditional): Renamed from decode_unconditional. > > This is OK. > Tested cvs trunk on armv7-unknown-linux-gnueabi. No regression. Checked in. http://sourceware.org/ml/gdb-cvs/2011-04/msg00183.html -- Yao (齐尧)