From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13397 invoked by alias); 19 Apr 2011 07:01:37 -0000 Received: (qmail 13388 invoked by uid 22791); 19 Apr 2011 07:01:36 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 Apr 2011 07:01:19 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p3J71ItX021636 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 19 Apr 2011 03:01:18 -0400 Received: from dhcp-25-89.brq.redhat.com (pdp-11.brq.redhat.com [10.34.24.63]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p3J71H50019109; Tue, 19 Apr 2011 03:01:18 -0400 Message-ID: <4DAD333D.6010103@redhat.com> Date: Tue, 19 Apr 2011 07:01:00 -0000 From: Marek Polacek User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100827 Red Hat Thunderbird/3.1.3 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb.base/setshow.exp: fix racy tests (PR testsuite/12649) References: <4DAC6924.2000100@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00295.txt.bz2 On 04/18/2011 10:45 PM, Tom Tromey wrote: > Marek> - gdb_test_multiple "set prompt (gdb) " "set prompt gdb" { > Marek> + gdb_test_multiple "set prompt \\(gdb\\) " "set prompt gdb" { > > I think this should not be needed. It is needed. Not that I'd see WHY it is so. But this is what I get without those "\\": FAIL: gdb.base/setshow.exp: set radix 11 FAIL: gdb.base/setshow.exp: set radix 16 FAIL: gdb.base/setshow.exp: show radix (16) FAIL: gdb.base/setshow.exp: set radix 10 FAIL: gdb.base/setshow.exp: show radix (10) FAIL: gdb.base/setshow.exp: set width 90 FAIL: gdb.base/setshow.exp: show width (90) FAIL: gdb.base/setshow.exp: set write on FAIL: gdb.base/setshow.exp: show write (on) FAIL: gdb.base/setshow.exp: set symbol-reloading on FAIL: gdb.base/setshow.exp: show symbol-reloading (on) FAIL: gdb.base/setshow.exp: show user FAIL: gdb.base/setshow.exp: set verbose on FAIL: gdb.base/setshow.exp: show verbose (on) FAIL: gdb.base/setshow.exp: set verbose off FAIL: gdb.base/setshow.exp: show verbose (off) === gdb Summary === # of expected passes 60 # of unexpected failures 16 _With_ them all seems just fine: === gdb Summary === # of expected passes 76 Marek