From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10969 invoked by alias); 16 Apr 2011 16:47:12 -0000 Received: (qmail 10950 invoked by uid 22791); 16 Apr 2011 16:47:11 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-ey0-f169.google.com (HELO mail-ey0-f169.google.com) (209.85.215.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 16 Apr 2011 16:46:57 +0000 Received: by eyd9 with SMTP id 9so1122232eyd.0 for ; Sat, 16 Apr 2011 09:46:56 -0700 (PDT) Received: by 10.14.119.14 with SMTP id m14mr406566eeh.209.1302972415890; Sat, 16 Apr 2011 09:46:55 -0700 (PDT) Received: from [192.168.2.100] (ip82-139-82-5.lijbrandt.net [82.139.82.5]) by mx.google.com with ESMTPS id x54sm2805911eeh.5.2011.04.16.09.46.54 (version=SSLv3 cipher=OTHER); Sat, 16 Apr 2011 09:46:55 -0700 (PDT) Message-ID: <4DA9C7FE.8020600@gmail.com> Date: Sat, 16 Apr 2011 16:47:00 -0000 From: "Baars, M.J." User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.14) Gecko/20110223 Thunderbird/3.1.8 MIME-Version: 1.0 To: Mark Kettenis CC: dan@codesourcery.com, gdb-patches@sourceware.org, gdb@sourceware.org Subject: Re: print_npx_status_word References: <4DA7ED79.3000400@gmail.com> <4DA87235.7060003@gmail.com> <4DA87479.50203@gmail.com> <4DA93270.6030708@gmail.com> <201104160824.p3G8ONWV006175@glazunov.sibelius.xs4all.nl> <4DA99DA1.2090708@gmail.com> <20110416142809.GA28255@caradoc.them.org> <4DA9C1FC.8040600@gmail.com> <201104161630.p3GGUSsS026236@glazunov.sibelius.xs4all.nl> In-Reply-To: <201104161630.p3GGUSsS026236@glazunov.sibelius.xs4all.nl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00247.txt.bz2 On 04/16/2011 06:30 PM, Mark Kettenis wrote: >> Date: Sat, 16 Apr 2011 18:21:16 +0200 >> From: "Baars, M.J." >> >> On 04/16/2011 04:29 PM, Daniel Jacobowitz wrote: >>> On Sat, Apr 16, 2011 at 03:46:09PM +0200, Baars, M.J. wrote: >>>> On 04/16/2011 10:24 AM, Mark Kettenis wrote: >>>>>> Date: Sat, 16 Apr 2011 08:08:48 +0200 >>>>>> From: "Baars, M.J." >>>>>> >>>>>> Hi Tom, >>>>>> >>>>>> I believe this is the format you requested? >>>>> No! This is a .tar.gz. Proper diffs don't come as a .tar.gz. >>>> Oops... did I remove one of your entries in the ChangeLog? :) >>> If you want a patch to be committed, eventually you're going to have >>> to say why. What's the goal of the patch? >> When you look at the code in question more closely, you will see that it >> will present the content of the status word in more detail than the >> original function, > Which isn't necessarily a good thing. I'll show you the difference in output after the 'info float' command. original output: Status Word: 0x0000 TOP: 0 new and improved output: status word : 0x0000 exception flags : stack fault : 0 error summary status : 0 busy : 0 top of stack pointer : 0 condition code : This will give you a much better overview of what is actually happing in the numeric core, which is eventually what every programmer wants is what I was always taught. >>> Also, why on earth are you messing about with old changelog entries? >>> >> The old function can thus be seen as obsolete, and should be removed >> from the old log entries. > Seems you totally fail to understand what ChangeLogs are for. Would you rather have obsolete function names flying all over the place then? I don't understand, eventually this will get you into trouble. Regards, Michael