From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-80346-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2446 invoked by alias); 15 Apr 2011 18:37:27 -0000
Received: (qmail 2390 invoked by uid 22791); 15 Apr 2011 18:37:26 -0000
X-SWARE-Spam-Status: No, hits=-1.4 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mailgw.tensilica.com (HELO mailgw.tensilica.com) (65.119.96.134)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 15 Apr 2011 18:37:21 +0000
Received: from localhost (unknown [127.0.0.1])	by mailgw.tensilica.com (Postfix) with ESMTP id 457D51160503;	Fri, 15 Apr 2011 18:37:21 +0000 (UTC)
Received: from mailgw.tensilica.com ([127.0.0.1]) by localhost (mailgw.tensilica.com [127.0.0.1]) (amavisd-maia, port 10024) with ESMTP id 11581-06; Fri, 15 Apr 2011 11:37:21 -0700 (PDT)
Received: from mail.tensilica.com (mail.tensilica.com [192.168.15.138])	by mailgw.tensilica.com (Postfix) with ESMTP id F33EF1160501;	Fri, 15 Apr 2011 11:37:20 -0700 (PDT)
Received: from [192.168.11.68] (192.168.11.68) by mail.tensilica.com (192.168.15.138) with Microsoft SMTP Server id 8.2.254.0; Fri, 15 Apr 2011 11:37:21 -0700
Message-ID: <4DA89060.9020401@tensilica.com>
Date: Fri, 15 Apr 2011 18:37:00 -0000
From: Maxim Grigoriev <maxim@tensilica.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.10
MIME-Version: 1.0
To: Tom Tromey <tromey@redhat.com>
CC: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>,	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA-v2] xtensa-tdep.c ARI fixes
References: <15837.6740910628$1302342165@news.gmane.org>	<m34o60fuc2.fsf@fleche.redhat.com>	<37948.3434990563$1302853234@news.gmane.org> <m3aafrcr4d.fsf@fleche.redhat.com>
In-Reply-To: <m3aafrcr4d.fsf@fleche.redhat.com>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-04/txt/msg00228.txt.bz2

I tested the patch. No problems have been detected.
Thanks much for improving Xtensa code.

-- Maxim

On 04/15/2011 11:21 AM, Tom Tromey wrote:
>>>>>> "Pierre" == Pierre Muller<pierre.muller@ics-cnrs.unistra.fr>  writes:
>>>>>>              
> Pierre>    Here is a new version that adds this xfree call.
> Pierre>  Could someone test this patch out?
> Pierre>  Again, I have no way to trigger that code, so I can't really test it.
>
> The patch looks good to me.
> But I agree, testing would be nice.
>
> Pierre>  +	&&   (i == C0_RA || cache->c0.c0_rt[i].fr_reg != C0_RA);
>
> Extra space after the "&&" :-)
>
> Tom
>