From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25764 invoked by alias); 13 Apr 2011 21:20:03 -0000 Received: (qmail 25737 invoked by uid 22791); 13 Apr 2011 21:20:02 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e24smtp05.br.ibm.com (HELO e24smtp05.br.ibm.com) (32.104.18.26) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Apr 2011 21:19:56 +0000 Received: from /spool/local by e24smtp05.br.ibm.com with XMail ESMTP for from ; Wed, 13 Apr 2011 18:19:55 -0300 Received: from mailhub1.br.ibm.com ([9.18.232.109]) by e24smtp05.br.ibm.com ([10.172.0.141]) with XMail ESMTP; Wed, 13 Apr 2011 18:19:52 -0300 Received: from d24av03.br.ibm.com (d24av03.br.ibm.com [9.8.31.95]) by mailhub1.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p3DLKgos1175772 for ; Wed, 13 Apr 2011 18:20:42 -0300 Received: from d24av03.br.ibm.com (loopback [127.0.0.1]) by d24av03.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p3DLJpq9009888 for ; Wed, 13 Apr 2011 18:19:51 -0300 Received: from [9.12.224.102] ([9.12.224.102]) by d24av03.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p3DLJm5j009867; Wed, 13 Apr 2011 18:19:49 -0300 Message-ID: <4DA6136F.8060907@linux.vnet.ibm.com> Date: Wed, 13 Apr 2011 21:20:00 -0000 From: Edjunior Barbosa Machado User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.16) Gecko/20110303 Lightning/1.0b1 Icedove/3.0.11 MIME-Version: 1.0 To: Jan Kratochvil CC: "gdb-patches@sourceware.org" , Yao Qi Subject: Re: [patch] Re: "optimized out" on gdb.base/gdb1090.exp References: <20110413111504.GA28987@host1.jankratochvil.net> In-Reply-To: <20110413111504.GA28987@host1.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit x-cbid: 11041321-2362-0000-0000-0000028AB754 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00198.txt.bz2 On 04/13/2011 08:15 AM, Jan Kratochvil wrote: > On Tue, 12 Apr 2011 23:21:48 +0200, Edjunior Barbosa Machado wrote: >> Checking out the original PR 1090 that originated this testcase, it doesn't >> mention any particularity regarding frame or backtrace, which leads me to >> believe that changing where 'print' is called should not affect the main >> focus of the testcase. > > PR 1090 should have been about "allocate a variable into multiple registers" > which is still being tested so the testcase should be OK even this way. > <2><8d>: Abbrev Number: 8 (DW_TAG_variable) > <8e> DW_AT_name : s24 > [...] > <98> DW_AT_location : 6 byte block: 53 93 4 56 93 4 (DW_OP_reg3 (ebx); DW_OP_piece: 4; DW_OP_reg6 (esi); DW_OP_piece: 4) > > > On Wed, 13 Apr 2011 03:26:11 +0200, Yao Qi wrote: >> On 04/13/2011 05:21 AM, Edjunior Barbosa Machado wrote: >>> >>> 2011-04-12 Edjunior Machado >>> >>> * testsuite/gdb.base/gdb1090.exp: change breakpoint location to >>> read the >> >> Please remove spurious spaces between "to" and "read". >> >>> content of 's24' correctly (avoiding "optimized out"). >>> * testsuite/gdb.base/gdb1090.c: add comment in order to set breakpoint. >> ^^^^^^^^^ Delete "testsuite/", since this changelog entry will >> go to gdb/testsuite/ChangLog. > > And the first letter of the sentence should be capital. > http://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html#Style-of-Change-Logs > > Please check it in with those changes. > > > Thanks, > Jan > Thanks Jan and Yao Qi for the feedback. Checked in with the mentioned changes: http://sourceware.org/ml/gdb-cvs/2011-04/msg00083.html -- Edjunior